Fix issue with flexShrink#53758
Closed
rozele wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
facebook-github-bot
added
p: Facebook
rozele
added a commit
to rozele/yoga
that referenced
this pull request
Sep 15, 2025
Summary: X-link: react/react-native#53758 In cases where the remaining space for flex shrink is negative, we can get into a state where the `totalFlexShrinkScaledFactors` get's infintesimally small, but likely should just be floored to zero. This manifests in issues where flexShrink nodes are suddenly given way too much space, and generally only manifests in an issue if these flexShrink nodes have self-measuring children (such as text). Checking if the value is approximately zero appears to fix bugs for flexShrink. Reviewed By: andrewdacenko Differential Revision: D82313674
rozele
added a commit
to rozele/yoga
that referenced
this pull request
Oct 11, 2025
Summary: X-link: react/react-native#53758 In cases where the remaining space for flex shrink is negative, we can get into a state where the `totalFlexShrinkScaledFactors` get's infintesimally small, but likely should just be floored to zero. This manifests in issues where flexShrink nodes are suddenly given way too much space, and generally only manifests in an issue if these flexShrink nodes have self-measuring children (such as text). Checking if the value is approximately zero appears to fix bugs for flexShrink. Reviewed By: andrewdacenko Differential Revision: D82313674
rozele
force-pushed
the
export-D82313674
branch
from
051e087 to
6e226cd
Compare
Summary: X-link: react/yoga#1855 In cases where the remaining space for flex shrink is negative, we can get into a state where the `totalFlexShrinkScaledFactors` get's infintesimally small, but likely should just be floored to zero. This manifests in issues where flexShrink nodes are suddenly given way too much space, and generally only manifests in an issue if these flexShrink nodes have self-measuring children (such as text). Checking if the value is approximately zero appears to fix bugs for flexShrink. Reviewed By: andrewdacenko Differential Revision: D82313674
rozele
force-pushed
the
export-D82313674
branch
from
6e226cd to
14b7652
Compare
rozele
added a commit
to rozele/yoga
that referenced
this pull request
Oct 11, 2025
Summary: X-link: react/react-native#53758 In cases where the remaining space for flex shrink is negative, we can get into a state where the `totalFlexShrinkScaledFactors` get's infintesimally small, but likely should just be floored to zero. This manifests in issues where flexShrink nodes are suddenly given way too much space, and generally only manifests in an issue if these flexShrink nodes have self-measuring children (such as text). Checking if the value is approximately zero appears to fix bugs for flexShrink. Reviewed By: andrewdacenko Differential Revision: D82313674
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
Stale
Collaborator
|
Closing this PR as the diff D82313674 has been abandoned internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In cases where the remaining space for flex shrink is negative, we can get into a state where the
totalFlexShrinkScaledFactorsget's infintesimally small, but likely should just be floored to zero.This manifests in issues where flexShrink nodes are suddenly given way too much space, and generally only manifests in an issue if these flexShrink nodes have self-measuring children (such as text).
Checking if the value is approximately zero appears to fix bugs for flexShrink.
Differential Revision: D82313674