Remove accidental ref callback return values (#57849) - #57849
Closed
javache wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115064073. |
meta-codesync
Bot
changed the title
javache
added a commit
to javache/react-native
that referenced
this pull request
Aug 7, 2026
Summary: Ref callbacks commonly used expression bodies that returned assignment or collection method results. Use block bodies so these callbacks return `void`, matching React's ref contract. Changelog: [Internal] - Make callback refs return `void` explicitly. Differential Revision: D115064073
javache
force-pushed
the
export-D115064073
branch
from
August 7, 2026 09:52
9a22438 to
9e3c9c3
Compare
javache
force-pushed
the
export-D115064073
branch
from
August 17, 2026 15:40
9e3c9c3 to
c32ef4d
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Aug 17, 2026
Summary: Ref callbacks commonly used expression bodies that returned assignment or collection method results. Use block bodies so these callbacks return `void`, matching React's ref contract. Changelog: [Internal] - Make callback refs return `void` explicitly. Reviewed By: SamChou19815 Differential Revision: D115064073
Summary: Ref callbacks commonly used expression bodies that returned assignment or collection method results. Use block bodies so these callbacks return `void`, matching React's ref contract. Changelog: [Internal] - Make callback refs return `void` explicitly. Reviewed By: SamChou19815 Differential Revision: D115064073
javache
force-pushed
the
export-D115064073
branch
from
August 18, 2026 09:52
c32ef4d to
3cecf9d
Compare
|
This pull request has been merged in 2ce2c07. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Ref callbacks commonly used expression bodies that returned assignment or collection method results. Use block bodies so these callbacks return
void, matching React's ref contract.Changelog:
[Internal] - Make callback refs return
voidexplicitly.Reviewed By: SamChou19815
Differential Revision: D115064073