fix: preferred pm logic enhancement #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiAndreiev
changed the title
AndriiAndreiev
added
the
area:api
erunion
requested changes
May 30, 2025
| * the current working directory. It then returns the directory name of the storage path. | ||
| * | ||
| */ | ||
| static getProjectDir() { |
There was a problem hiding this comment.
Mind adding a small test for this?
erunion
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Enhances the preferable-pm detection logic to additionally consider the root project's configuration, improving accuracy in multi-package setups. This PR is required for #1027 (Yarn support) and will support future package manager integrations.
🧬 QA & Testing
Create a Yarn/Bun/PNPM-based project, run the installation process, and log the preferable-pm output.