Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EthicalAd: implement better positioning #311

Open
humitos opened this issue May 21, 2024 · 1 comment · May be fixed by #447
Open

EthicalAd: implement better positioning #311

humitos opened this issue May 21, 2024 · 1 comment · May be fixed by #447
Labels
Needed: design decision A core team decision is required

Comments

@humitos
Copy link
Member

humitos commented May 21, 2024

We wrote the logic we want to implement in #295 (comment)

Placement preference for RTD ad injection:

Using stickybox image (These float if the screen is wide, automatically):

  • Sidebar like content (role=sidebar) (Currently we check for sidebar height, and if it's too long, we put it in the footer -- but this is probably not necessary?)
  • Footer like content (role=footer)
  • Main body content (role=main)

Using text:

  • Fixed footer (Not conflicting with the flyout?)

It would be good to review it again when polishing the ad integration.
@humitos humitos mentioned this issue May 29, 2024
Closed
@humitos
Copy link
Member Author

humitos commented May 29, 2024

After the initial deploy from yesterday, we may reconsider this and avoid showing an ad if it doesn't fit in the screen in a well known position.

@humitos humitos added the Needed: design decision A core team decision is required label Jul 9, 2024
@humitos humitos linked a pull request Jan 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needed: design decision A core team decision is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EthicalAds: Default to fixedfooter for smaller screens readthedocs/addons
1 participant
@humitos