Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't inject content that only works online for offline formats #28

Closed
stsewd opened this issue Jul 16, 2019 · 0 comments · Fixed by #29
Closed

Don't inject content that only works online for offline formats #28

stsewd opened this issue Jul 16, 2019 · 0 comments · Fixed by #29
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Jul 16, 2019

This extension only works when the content is online, but we also generate downloadable files for offline reading.

Ref: readthedocs/readthedocs-sphinx-ext#63 (comment)

It probably needs to replicate the ONLINE_BUILDERS list from the other extension
@dojutsu-user dojutsu-user added Accepted Accepted issue on our roadmap Improvement Minor improvement to code labels Jul 17, 2019
@dojutsu-user dojutsu-user mentioned this issue Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log the info when extension is not running on RTD readthedocs/readthedocs-sphinx-search
2 participants
@stsewd @dojutsu-user