From 380d64b34d2cd8e32cfa1fdb43d1f60f45634b71 Mon Sep 17 00:00:00 2001
From: Manuel Kaufmann <humitos@gmail.com>
Date: Mon, 9 Dec 2024 16:55:39 +0100
Subject: [PATCH] Requirements: update django-formtools (#11822)

Let's see if tests pass first. If so, we can remove the internal check
we added for conditional dict, and perform a manual import to check if
the notification is duplicated.

Related https://github.com/readthedocs/readthedocs.org/pull/11795
---
 requirements/deploy.txt  | 2 +-
 requirements/docker.txt  | 2 +-
 requirements/pip.in      | 4 +---
 requirements/pip.txt     | 2 +-
 requirements/testing.txt | 2 +-
 5 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/requirements/deploy.txt b/requirements/deploy.txt
index b96217eb8ec..0029c598cac 100644
--- a/requirements/deploy.txt
+++ b/requirements/deploy.txt
@@ -151,7 +151,7 @@ django-extensions==3.2.3
     # via -r requirements/pip.txt
 django-filter==24.3
     # via -r requirements/pip.txt
-django-formtools==2.3
+django-formtools==2.5.1
     # via -r requirements/pip.txt
 django-gravatar2==1.4.5
     # via -r requirements/pip.txt
diff --git a/requirements/docker.txt b/requirements/docker.txt
index 878d2489f01..718392b56e1 100644
--- a/requirements/docker.txt
+++ b/requirements/docker.txt
@@ -161,7 +161,7 @@ django-extensions==3.2.3
     # via -r requirements/pip.txt
 django-filter==24.3
     # via -r requirements/pip.txt
-django-formtools==2.3
+django-formtools==2.5.1
     # via -r requirements/pip.txt
 django-gravatar2==1.4.5
     # via -r requirements/pip.txt
diff --git a/requirements/pip.in b/requirements/pip.in
index 298cab23965..03a6a14508e 100644
--- a/requirements/pip.in
+++ b/requirements/pip.in
@@ -126,9 +126,7 @@ markdown
 
 unicode-slugify
 
-# Version 2.4 makes tests to fail with:
-# "RecursionError: maximum recursion depth exceeded in comparison"
-django-formtools<2.4
+django-formtools
 
 # We cannot upgrade to >=2 because it fails with
 # django.template.exceptions.TemplateDoesNotExist: bootstrap/field.html
diff --git a/requirements/pip.txt b/requirements/pip.txt
index fde936d5f6a..a9a40af148e 100644
--- a/requirements/pip.txt
+++ b/requirements/pip.txt
@@ -113,7 +113,7 @@ django-extensions==3.2.3
     # via -r requirements/pip.in
 django-filter==24.3
     # via -r requirements/pip.in
-django-formtools==2.3
+django-formtools==2.5.1
     # via -r requirements/pip.in
 django-gravatar2==1.4.5
     # via -r requirements/pip.in
diff --git a/requirements/testing.txt b/requirements/testing.txt
index 32fc7dfd22e..99a9ad1c042 100644
--- a/requirements/testing.txt
+++ b/requirements/testing.txt
@@ -158,7 +158,7 @@ django-extensions==3.2.3
     # via -r requirements/pip.txt
 django-filter==24.3
     # via -r requirements/pip.txt
-django-formtools==2.3
+django-formtools==2.5.1
     # via -r requirements/pip.txt
 django-gravatar2==1.4.5
     # via -r requirements/pip.txt