Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove project.documentation_type from all our serving code, and models #10083

Open
ericholscher opened this issue Feb 28, 2023 · 2 comments · May be fixed by #10042
Open

Remove project.documentation_type from all our serving code, and models #10083

ericholscher opened this issue Feb 28, 2023 · 2 comments · May be fixed by #10042
Assignees
@humitos

Comments

@ericholscher
Copy link
Member

I did a quick grep for this and it seems there is not many places where we have logic that's based on this field: #10042
@ericholscher ericholscher converted this from a draft issue Feb 28, 2023
@ericholscher ericholscher linked a pull request Feb 28, 2023 that will close this issue
Refactor: remove Version.documentation_type #10042
Draft
@humitos humitos moved this from Planned to In progress in 📍Roadmap Mar 2, 2023
@ericholscher ericholscher moved this from In progress to Planned in 📍Roadmap Apr 9, 2024
@htech9
Copy link

htech9 commented Sep 22, 2024

@ericholscher @humitos this is just a friendly heads up to ask if some action need to be done on this PR regarding fact
the referred implementation at https://github.com/readthedocs/readthedocs.org/pull/10042 looks stale for a while now?

@humitos
Copy link
Member

humitos commented Sep 23, 2024

Hi @htech9. Yes, there are still work that need to happen before being able to move forward. We detailed it at #10042 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: remove Version.documentation_type readthedocs/readthedocs.org
3 participants
@ericholscher @humitos @htech9