Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: git backend shouldn't rely on verbose_name to identify latest/stable #11955

Open
stsewd opened this issue Jan 27, 2025 · 1 comment
Open

Comments

@stsewd
Copy link
Member

stsewd commented Jan 27, 2025

What's the problem this feature will solve?

Around our code base, we always use the slug and machine attribute to identify latest/stable versions, we should use that everywhere, here we are using the verbose name instead.

if self.version_machine and self.verbose_name == STABLE_VERBOSE_NAME:
if self.version_identifier:
return f"{self.version_identifier}"
log.error("'stable' version without a commit hash.")
return None
tag_name = self.verbose_name
# For a machine created "latest" tag, the name of the tag is set
# in the `Version.identifier` field, note that it isn't a commit
# hash, but the name of the tag.
if self.version_machine and self.verbose_name == LATEST_VERBOSE_NAME:

Describe the solution you'd like

Use the slug, or maybe refactor this so it doesn't depend several values.

Alternative solutions

None

Additional context

ref #11941

@humitos
Copy link
Member

humitos commented Jan 29, 2025

I'm adding this to a future sprint on February because it's related to the work we are doing on changing version's slugs and it seems important to not loose it while we are working/testing that feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

No branches or pull requests

2 participants