HTMLZip output shouldn't include/point to online resources

[agjohnson]

Console log report from a user:

Failed to load resource: net::ERR_FILE_NOT_FOUND
readthedocs-dynamic-include.js Failed to load resource: net::ERR_FILE_NOT_FOUND
index.html:53 Uncaught ReferenceError: READTHEDOCS_DATA is not defined
at index.html:53
index.html:4608 Uncaught ReferenceError: SphinxRtdTheme is not defined
at HTMLDocument.<anonymous> (index.html:4608)
at j (jquery.js:2)
at Object.fireWith [as resolveWith] (jquery.js:2)
at Function.ready (jquery.js:2)
at HTMLDocument.J (jquery.js:2)

[ianbarker253]

This issue is also effecting us. All of the HTMLZip files for all versions the Search functionality is broken. I saw the above error and when ever someone executes a search the 'search.html' is not found.

[stsewd]

Also, the version selector is broken, the data.js file is missing (I think this is injected only in the main html build process)

[stsewd]

Related to #4452

[stsewd]

So, I think we could edit the builders to not use the readthedocs builder, but only html builder when building the downloable docs, since they aren't used online anyway.

[stsewd]

Actually search shouldn't be shown here, we provide singlethml versions of the docs to download. See #5359. But this is still relevant because we are including links to online resources

Like #2637 (comment)

[stsewd]

readthedocs/readthedocs-sphinx-ext#63 will remove the online resources, but we are going to still see the footer with some dummy/invalid links. The only thing I see is removing this from the theme https://github.com/rtfd/sphinx_rtd_theme/blob/ddfdd35e6977f21fb1771734732756b0cf1d6bba/sphinx_rtd_theme/versions.html#L1

[humitos]

@stsewd maybe that line you linked in the theme could check for something like:

{% if READTHEDOCS and app.builder.name != "singlehtml" %}