-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: show the command that's currently being executed #4288
Comments
I think it makes sense to save the command before running with just the command that's going to be executed and after it's has finished with all the details (end time, exit code, etc) or adding a custom message in the output if the command has failed. I'm not sure how easy would be the latter. |
This issue is related (maybe duplicated) to an old one: #1863 |
1 similar comment
This issue is related (maybe duplicated) to an old one: #1863 |
It seems like this is going to 2x the amount of API calls we'll need for every build, with each command now requiring a "start" and "end" API call? |
Yeah, but we are using a patch method, so less info. And we already call the api a lot to do the live report (but that's a read only operation) |
But the live report is only for users watching the build. |
I had a user request this, and think it's definitely something worth doing, especially for long-running build steps like the HTML build. It is kinda weird that it just spins for ~20 minutes for some longer builds without showing what is happening. I put a bit more data here: #11933 Related to readthedocs/ext-theme#171 |
Currently, we save the command after running it, which has this two problems:
I have played a little with the save command and the API, is possible to do this, we only need to be careful with the data that is saved before the command is executed (for the current API some values like
end_time
can't be None).ref #3884 and other related issues
The text was updated successfully, but these errors were encountered: