Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private versions are not accessible even by admins #5253

Closed
nadiaya opened this issue Feb 7, 2019 · 25 comments
Closed

Private versions are not accessible even by admins #5253

nadiaya opened this issue Feb 7, 2019 · 25 comments
Labels
Bug A bug Status: blocked Issue is blocked on another issue

Comments

@nadiaya
Copy link

nadiaya commented Feb 7, 2019

Details

Private documentation version is not accessible even by admins: 'Permission Denied' returned to everyone.

Expected Result

After making 'latest' version to be private, according to https://docs.readthedocs.io/en/latest/privacy.html#private, we should be able to view the documentation for this version when logged in an admin account for this project.

Actual Result

When going to https://sagemaker.readthedocs.io/en/latest/ getting 'Permission Denied' even when logged in an admin account.

@stsewd
Copy link
Member

stsewd commented Feb 17, 2019

Are you still having this problem? Also, I only see one maintainer in the project (awsml).

And we are about to remove/deprecate the privacy levels #2663

@stsewd stsewd added Support Support question Needed: more information A reply from issue author is required labels Feb 17, 2019
@no-response
Copy link

no-response bot commented Mar 3, 2019

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. Thanks!

@no-response no-response bot closed this as completed Mar 3, 2019
@taradinoc
Copy link

@stsewd I'm experiencing this too.

https://mdl-language.readthedocs.io/en/latest/ - Public. No problems.

https://mdl-language.readthedocs.io/en/sphinx/ - Private. It has built successfully, but I can't view it even though I'm logged in as the only project maintainer.

@daianagan
Copy link

@taradinoc or anyone was able to solve this? I am still gettig the same error...

@dojutsu-user
Copy link
Member

@stsewd Seems like this is still valid. I am reopening the issue.

@dojutsu-user dojutsu-user reopened this Jul 13, 2019
@no-response
Copy link

no-response bot commented Jul 13, 2019

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. Thanks!

@no-response no-response bot closed this as completed Jul 13, 2019
@dojutsu-user dojutsu-user reopened this Jul 13, 2019
@dojutsu-user dojutsu-user removed the Needed: more information A reply from issue author is required label Jul 13, 2019
@stsewd stsewd added the Needed: replication Bug replication is required label Jul 13, 2019
@taradinoc
Copy link

@stsewd This is still reproducible using the links in my last comment. https://mdl-language.readthedocs.io/en/sphinx/ gives me a "Permission Denied" error even though I'm logged in as the admin.

@kmaehashi
Copy link

Same case here. https://docs.chainer.org/en/v6/ (v6 branch is set to Private) cannot be browsed even when I logged in as a maintainer account.

@stsewd
Copy link
Member

stsewd commented Jul 18, 2019

Hi all, we are planning to remove the privacy levels from the community site, since all projects hosted in readthedocs.org are public open source projects. If you are relying on this feature to host private versions, you should use readthedocs.com instead.

With that said, I don't think this bug isn't going to be fixed soon (the core team is going to put more effort into removing the privacy levels)

Ref #2663 #3781

If you are using private versions with public open source projects, we would love to hear your use cases.

@daianagan
Copy link

Dear @stsewd,
Thanks for your reply. I didn't know that readthedocs.org was exclusively for open source projects, I thought readthedocs is an OS project itself but not that it was made for OS only also.
In my case I work as a Bioinformatician in a public hospital in Argentina and regularly I document patient's info which of course cannot be public. Another example are hospital's SOPs which cannot be made available for everyone. I found readthedocs & sphinx to be a very friendly way to show the documentation, but it won't be possible in my case if it has to be either public or paid (and regretfully I have no resources to pay for documentation). Or do you plan to have an option for non-profitable organizations? :)
I think I'll use Sphinx and local files for now
Thank you for your help!!
Best regards,
Daiana

@stsewd
Copy link
Member

stsewd commented Jul 18, 2019

@daianagan we do offer a discount for non-profitable organizations, and if that isn't enough or you have more questions, please write us to [email protected]

@kmaehashi
Copy link

@stsewd Thank you for your reply! Let me explain our use-case.

We are currently developing in 2 branches; docs of master / v6 branches are built as latest / v6 version on RTD respectively. Our open-source project requires a bit complicated setup (building Python C++ extension modules that use CUDA), so we'd like to make sure that every commit of master / v6 branches can be built successfully on RTD to avoid tagging a commit which cannot render docs correctly. Actually we once experienced that issue; of course, we're testing every commit by running sphinx-build on our own CI, but it is difficult to correctly reproduce the RTD build container environment.

To avoid confusion to users (because v6 sounds like a docs of the latest released version of v6.x series, but actually it is a docs of HEAD of v6 branch), we had been using Protected settings to v6 branch, but unfortunately it was removed in #5833, so we considered migrating to Private, and found this issue.

I also think it's useful to have a Private mode as a "staging" feature so that we can try changing configuration in readthedocs.yml and see how it works in a separate branch. (So, actually what we need is the environment that can reproduce RTD results locally, not privacy levels.)

I understand that readthedocs.org is for public open source projects and thank you for providing a great service!

@stsewd
Copy link
Member

stsewd commented Jul 19, 2019

@kmaehashi would having build docs from a PR to preview the changes help with your use case? #1340

Also, we are going to have a replacement for protected, something like hide version, so those wouldn't be listed.

@kmaehashi
Copy link

kmaehashi commented Jul 26, 2019

@stsewd

would having build docs from a PR to preview the changes help with your use case? #1340

Yes, that feature would be very useful for us.

Also, we are going to have a replacement for protected, something like hide version, so those wouldn't be listed.

Thank you, looking forward to see that feature!

@stale
Copy link

stale bot commented Sep 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Sep 12, 2019
@saadmk11
Copy link
Member

Hi, @kmaehashi. We have The PR Builder Feature in BETA now. You can learn more about it in this blog post: https://blog.readthedocs.com/building-docs-for-pull-requests/

@stale stale bot removed the Status: stale Issue will be considered inactive soon label Sep 12, 2019
@kmaehashi
Copy link

@saadmk11 Thanks for letting me know! I'll look into it.

@bsipocz
Copy link
Contributor

bsipocz commented Oct 8, 2019

Also, we are going to have a replacement for protected, something like hide version, so those wouldn't be listed.

do you have an ETA for this? We routinely used the "Protected" feature to hide our older versions, while keeping the direct lint to it alive. IMO the confusion could have been cleaned up with documentation rather than punishing with removal for those who it as intended.

@stsewd
Copy link
Member

stsewd commented Oct 8, 2019

We don't have a specific date, but it's on our roadmap #6194

@stsewd stsewd removed the Needed: replication Bug replication is required label Oct 17, 2019
@stsewd stsewd added Bug A bug Status: blocked Issue is blocked on another issue and removed Support Support question labels Oct 17, 2019
@Borda
Copy link

Borda commented Nov 15, 2019

@humitos
Copy link
Member

humitos commented Nov 18, 2019

I think we can close this issue. We are not going to support PRIVATE versions on readthedocs.org --although, they will be fully supported on readthedocs.com

@humitos humitos closed this as completed Nov 18, 2019
@Borda
Copy link

Borda commented Nov 18, 2019

So pls disable such option.

@humitos
Copy link
Member

humitos commented Nov 18, 2019

@Borda we are working on that. Thanks,

@zilinc
Copy link

zilinc commented Dec 21, 2019

I'm new to rtd. My use case is that I use private versions for debugging my docs (or as a preview as I fix things). Is there an alternative to it? Thanks in advance.

@humitos
Copy link
Member

humitos commented Dec 22, 2019

@zilinc Hi! As mentioned in this issue, we are removing the support for private versions. In case you want to have "preview" of what a version will look like, you can ask to enable PR builder in your project. See https://blog.readthedocs.com/building-docs-for-pull-requests/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Status: blocked Issue is blocked on another issue
Projects
None yet
Development

No branches or pull requests