Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Integration models to use django-polymorphic #5394

Open
stsewd opened this issue Mar 4, 2019 · 9 comments
Open

Refactor Integration models to use django-polymorphic #5394

stsewd opened this issue Mar 4, 2019 · 9 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Priority: low Low priority
Milestone
Refactoring

Comments

@stsewd
Copy link
Member

stsewd commented Mar 4, 2019

We are using a custom solution for that right now, we can migrate to django-polymorphic as #5323.

Migration guide https://django-polymorphic.readthedocs.io/en/stable/migrating.html

Raised in #5324 (comment)
@stsewd stsewd added Improvement Minor improvement to code Priority: low Low priority labels Mar 4, 2019
@stsewd stsewd added this to the Refactoring milestone Mar 4, 2019
@stsewd stsewd mentioned this issue Mar 4, 2019
Closed
@stale
Copy link

stale bot commented Apr 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Apr 18, 2019
@stsewd stsewd removed the Status: stale Issue will be considered inactive soon label Apr 18, 2019
@stale
Copy link

stale bot commented Jun 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jun 2, 2019
@dojutsu-user dojutsu-user removed the Status: stale Issue will be considered inactive soon label Jun 2, 2019
@stsewd stsewd added the Accepted Accepted issue on our roadmap label Jun 2, 2019
@Iamshankhadeep
Copy link
Contributor

@stsewd is this still needed?

@stsewd
Copy link
Member Author

stsewd commented Oct 11, 2019

Yes

@Iamshankhadeep
Copy link
Contributor

Can I work on it then?

@saadmk11
Copy link
Member

Sure! Go Ahead 👍

@Iamshankhadeep
Copy link
Contributor

@stsewd do I need to refactor this file only?

@stsewd
Copy link
Member Author

stsewd commented Oct 14, 2019

@Iamshankhadeep all files that are required for django polymorphic to work. You should read the django polymorphic docs. Also, maybe this isn't a good first issue to start if you are not familiar with django.

@Iamshankhadeep
Copy link
Contributor

@stsewd That's why I want to work on this issue and to learn Django, hope you all will support me while I learn about all the things that are new to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Priority: low Low priority
Projects
None yet
Milestone
Refactoring
Development

No branches or pull requests
4 participants
@stsewd @Iamshankhadeep @saadmk11 @dojutsu-user