From f9e1b99b356dc02d63c557d7dc34ca52d4dafa26 Mon Sep 17 00:00:00 2001 From: LJ <81748770+elle-j@users.noreply.github.com> Date: Fri, 31 May 2024 14:44:51 +0200 Subject: [PATCH] Update error message from 'floating point' to 'decimal'. --- integration-tests/tests/src/tests/counter.ts | 6 +++--- packages/realm/src/errors.ts | 7 +++---- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/integration-tests/tests/src/tests/counter.ts b/integration-tests/tests/src/tests/counter.ts index c16b680c84..55ef4ad98f 100644 --- a/integration-tests/tests/src/tests/counter.ts +++ b/integration-tests/tests/src/tests/counter.ts @@ -477,7 +477,7 @@ describe("Counter", () => { this.realm.write(() => { counter.increment(1.1); }); - }).to.throw("Expected 'by' to be an integer, got a floating point number"); + }).to.throw("Expected 'by' to be an integer, got a decimal number"); expect(counter.value).equals(10); expect(() => { @@ -525,7 +525,7 @@ describe("Counter", () => { this.realm.write(() => { counter.decrement(1.1); }); - }).to.throw("Expected 'by' to be an integer, got a floating point number"); + }).to.throw("Expected 'by' to be an integer, got a decimal number"); expect(counter.value).equals(10); expect(() => { @@ -573,7 +573,7 @@ describe("Counter", () => { this.realm.write(() => { counter.set(1.1); }); - }).to.throw("Expected 'value' to be an integer, got a floating point number"); + }).to.throw("Expected 'value' to be an integer, got a decimal number"); expect(counter.value).equals(10); expect(() => { diff --git a/packages/realm/src/errors.ts b/packages/realm/src/errors.ts index f53ec2347b..9c70d9ae5d 100644 --- a/packages/realm/src/errors.ts +++ b/packages/realm/src/errors.ts @@ -46,13 +46,12 @@ export class TypeAssertionError extends AssertionError { } else if (typeof value === "function") { return `a function or class named ${value.name}`; } else if (typeof value === "number") { - let type = "a number"; if (Number.isNaN(value)) { - type = "NaN"; + return "NaN"; } else if (!Number.isInteger(value)) { - type = "a floating point number"; + return "a decimal number"; } - return type; + return "a number"; } else { return "a " + typeof value; }