Merge pull request #180 from oleksandr-danylchenko/#179-fix-losing-same-annotation-reference

rsimon · web-flow · commit d82e9f9dd6ab · 2024-11-21T12:35:23.000+01:00
#179 Removed excessive selection cleanup
diff --git a/packages/text-annotator/src/SelectionHandler.ts b/packages/text-annotator/src/SelectionHandler.ts
@@ -219,7 +219,6 @@ export const SelectionHandler = (
         currentTarget = undefined;
         clickSelect();
       } else if (currentTarget && currentTarget.selector.length > 0) {
-        selection.clear();
         upsertCurrentTarget();
         selection.userSelect(currentTarget.annotation, clonePointerEvent(evt));
       }
@@ -247,7 +246,6 @@ export const SelectionHandler = (
       const sel = document.getSelection();
 
       if (!sel.isCollapsed) {
-        selection.clear();
         upsertCurrentTarget();
         selection.userSelect(currentTarget.annotation, cloneKeyboardEvent(evt));
       }

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,6 @@ export const SelectionHandler = (`
`219`	`219`	`currentTarget = undefined;`
`220`	`220`	`clickSelect();`
`221`	`221`	`} else if (currentTarget && currentTarget.selector.length > 0) {`
`222`		`- selection.clear();`
`223`	`222`	`upsertCurrentTarget();`
`224`	`223`	`selection.userSelect(currentTarget.annotation, clonePointerEvent(evt));`
`225`	`224`	`}`
`@@ -247,7 +246,6 @@ export const SelectionHandler = (`
`247`	`246`	`const sel = document.getSelection();`
`248`	`247`
`249`	`248`	`if (!sel.isCollapsed) {`
`250`		`- selection.clear();`
`251`	`249`	`upsertCurrentTarget();`
`252`	`250`	`selection.userSelect(currentTarget.annotation, cloneKeyboardEvent(evt));`
`253`	`251`	`}`