From d28f184d3e02d3885f117eb5cba4702382ef7b34 Mon Sep 17 00:00:00 2001 From: Oleksandr Danylchenko Date: Wed, 30 Oct 2024 17:28:54 +0200 Subject: [PATCH] Revert "Minor fix" This reverts commit fb3d70be --- packages/text-annotator/src/SelectionHandler.ts | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/packages/text-annotator/src/SelectionHandler.ts b/packages/text-annotator/src/SelectionHandler.ts index d198d4bb..84d45071 100644 --- a/packages/text-annotator/src/SelectionHandler.ts +++ b/packages/text-annotator/src/SelectionHandler.ts @@ -50,11 +50,7 @@ export const SelectionHandler = ( let lastDownEvent: Selection['event'] | undefined; - let isContextMenuOpen = false; - const onSelectStart = (evt: Event) => { - isContextMenuOpen = false; - if (isLeftClick === false) return; @@ -161,8 +157,6 @@ export const SelectionHandler = ( * to the initial pointerdown event and remember the button */ const onPointerDown = (evt: PointerEvent) => { - if (isContextMenuOpen) return; - if (isNotAnnotatable(evt.target as Node)) return; /** @@ -188,8 +182,6 @@ export const SelectionHandler = ( } const onPointerUp = (evt: PointerEvent) => { - if (isContextMenuOpen) return; - if (isNotAnnotatable(evt.target as Node) || !isLeftClick) return; // Logic for selecting an existing annotation @@ -239,8 +231,6 @@ export const SelectionHandler = ( } const onContextMenu = (evt: PointerEvent) => { - isContextMenuOpen = true; - const sel = document.getSelection(); if (sel?.isCollapsed) return; @@ -282,7 +272,7 @@ export const SelectionHandler = ( selection.userSelect(currentTarget.annotation, cloneKeyboardEvent(evt)); } - + document.removeEventListener('selectionchange', onSelected); // Sigh... this needs a delay to work. But doesn't seem reliable. @@ -290,7 +280,7 @@ export const SelectionHandler = ( // Listen to the change event that follows document.addEventListener('selectionchange', onSelected); - + // Start selection! onSelectStart(evt); }