Skip to content

Add EOL check for the cluster used for testing a chart (e.g. testedOpenShiftversion) #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
komish opened this issue Sep 19, 2024 · 2 comments · May be fixed by #499
Open

Add EOL check for the cluster used for testing a chart (e.g. testedOpenShiftversion) #474

komish opened this issue Sep 19, 2024 · 2 comments · May be fixed by #499
Assignees
@skattoju

Comments

@komish
Copy link
Contributor

komish commented Sep 19, 2024

It's logical to make sure that either

  • the cluster used for testing a chart with chart-verifier is not an OpenShift EOL cluster, or
  • the cluster used for testing a chart with chart-verifier fits within the kubeVersion range.

The former makes more sense, but may be a bit complicated to implement. We may be able to add and manage this information in a library https://github.com/opdev/getocprange, or otherwise need to talk to Pyxis to get this information (which adds a network call).
@acornett21
Copy link
Contributor

acornett21 commented Sep 19, 2024 •
edited
Loading

The logic for what you need can be found below:

https://github.com/redhat-openshift-ecosystem/operator-certification-operator/blob/c4530a7b805e5a7fb6eff9176ae69de2fd47e5fd/internal/pyxis/pyxis.go#L31-L72

@skattoju
Copy link

/assign

@skattoju skattoju linked a pull request Mar 31, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skattoju skattoju

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding eol check skattoju/chart-verifier
3 participants
@komish @skattoju @acornett21