From ad525edf1d4f21350137e258cc5f186fbb898fad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aur=C3=A9lien=20Pupier?= Date: Wed, 5 Jan 2022 11:48:44 +0100 Subject: [PATCH 1/2] FUSETOOLS2-1055 - provide trace when sending message to webview MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Aurélien Pupier --- src/didactPanel.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/didactPanel.ts b/src/didactPanel.ts index c45443b1..31a47c90 100644 --- a/src/didactPanel.ts +++ b/src/didactPanel.ts @@ -155,6 +155,7 @@ export class DidactPanel { if (sendUri) { jsonMsg = `{ ${sendCommand}, ${sendUri} }`; } + console.log('will post message sendSetStateMessage'); this._panel.webview.postMessage(jsonMsg); } @@ -326,6 +327,7 @@ export class DidactPanel { } public async dispose(): Promise { + console.log('dispoe called!'); if (this._disposed) { return; } @@ -370,6 +372,7 @@ export class DidactPanel { if (!this._panel) { return; } + console.log('will post message from postMessage '+message); const jsonMsg:string = "{ \"command\": \"sendMessage\", \"data\": \"" + message + "\"}"; this._panel.webview.postMessage(jsonMsg); } @@ -378,6 +381,7 @@ export class DidactPanel { if (!this._panel) { return; } + console.log('will post message from postRequirementsResponseMessage '); const jsonMsg:string = "{ \"command\": \"requirementCheck\", \"requirementName\": \"" + requirementName + "\", \"result\": \"" + result + "\"}"; this._panel.webview.postMessage(jsonMsg); await this.sendSetStateMessage(); @@ -388,6 +392,7 @@ export class DidactPanel { return; } const jsonMsg = `{ "command" : "${msg}"}`; + console.log('will post message from postNamedSimpleMessage '+msg); this._panel.webview.postMessage(jsonMsg); } @@ -416,6 +421,7 @@ export class DidactPanel { if (!this._panel || this._disposed) { return; } + console.log('will post mess age from sendScrollToHeadingMessage'); const jsonMsg = `{ "command": "scrollToHeading", "tag" : "${tag}", "headingText" : "${headingText}" }`; await this._panel.webview.postMessage(jsonMsg); } From cbc44ac568b749c4fe0f0571f9ef7c2088aa79a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aur=C3=A9lien=20Pupier?= Date: Wed, 5 Jan 2022 14:31:21 +0100 Subject: [PATCH 2/2] try to check for dispose --- src/didactPanel.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/didactPanel.ts b/src/didactPanel.ts index 31a47c90..2b687160 100644 --- a/src/didactPanel.ts +++ b/src/didactPanel.ts @@ -369,7 +369,7 @@ export class DidactPanel { } public async postMessage(message: string): Promise { - if (!this._panel) { + if (!this._panel || this._disposed) { return; } console.log('will post message from postMessage '+message); @@ -378,7 +378,7 @@ export class DidactPanel { } public async postRequirementsResponseMessage(requirementName: string, result: boolean): Promise { - if (!this._panel) { + if (!this._panel || this._disposed) { return; } console.log('will post message from postRequirementsResponseMessage '); @@ -388,7 +388,7 @@ export class DidactPanel { } async postNamedSimpleMessage(msg: string): Promise { - if (!this._panel) { + if (!this._panel || this._disposed) { return; } const jsonMsg = `{ "command" : "${msg}"}`;