You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
*[Contributing to this repository](#contributing-to-this-repository)
6
5
7
-
Pantheon 2 is a modular documentation management and publication system based on asciidoc
8
-
and built on top of Apache sling.
9
-
*[Contributing to Pantheon](#contributing-to-pantheon)
10
-
*[Installing Pantheon](#installing-pantheon)
11
-
*[Prerequisites](#prerequisites)
12
-
*[Environment Variables](#environment-variables)
13
-
*[Building the application](#building-the-application)
14
-
*[Unit tests](#unit-tests)
15
-
*[Running the application](#running-the-application)
16
-
*[Live deploy of code](#live-deploy-of-code)
17
-
*[Using the application](#using-the-application)
18
-
*[Other use cases](#other-use-cases)
19
-
*[Developing the frontend code](#developing-the-frontend-code)
20
-
*[End user documentation](#end-user-documentation)
6
+
## Contributing to this repository
21
7
22
-
##Contributing to Pantheon
8
+
### Filing a bug
23
9
24
-
### Filing a bug for Pantheon 2 end-user documentation
25
-
26
-
If you have any suggestions to improve or extend the end-user documentation, create a new issue and tag @pantheon-doc-authors.
10
+
If you have any suggestions to improve or extend this repository, add a new issue in the repository.
27
11
28
12
### Prerequisites
29
13
@@ -38,45 +22,44 @@ If you have any suggestions to improve or extend the end-user documentation, cre
38
22
39
23
Fork the repository so that you can create and work with branches independently of the `redhataccess/pantheon` repository.
40
24
41
-
1. In a web browser, navigate to https://github.com/redhataccess/pantheon
25
+
1. In a web browser, navigate to https://github.com/redhat-documentation/publishing-tutorial-sample-repo
42
26
1. Click **Fork**.
43
27
1. Click your user space in GitHub.
44
28
45
29
### Cloning the repository
46
30
47
-
After you have forked the repository, you must clone it to your local machine and add the original `redhataccess/pantheon` repository as an upstream remote.
31
+
After you have forked the repository, you must clone it to your local machine and add the original `redhat-documentation/publishing-tutorial-sample-repo` repository as an upstream remote.
Whenever you work on a new issue, you must create a new working branch based on the latest version of the upstream master branch.
47
+
Pull requests should have a corresponing issue in the repo. Whenever you work on a new issue, you must create a new working branch based on the latest version of the upstream main branch.
64
48
65
-
1. Ensure you are on master
49
+
1. Ensure you are on main
66
50
67
51
```sh
68
-
$ git checkout master
52
+
$ git checkout main
69
53
```
70
54
1. Ensure your fork is up to date
71
55
72
56
```sh
73
-
$ git pull upstream master
57
+
$ git pull upstream main
74
58
```
75
-
1. Create a working branch based on the issue in JIRA. For example:
76
-
59
+
1. Create a working branch based on the issue ID. For example for issue #2, you can use "2" or "02" for the branch name:
77
60
78
61
```sh
79
-
$ git checkout -b FCCEUD-<ID#>
62
+
$ git checkout -b 02
80
63
```
81
64
82
65
### Creating a pull request and completing review
@@ -90,11 +73,10 @@ When your work is ready to be reviewed and merged, create a pull request.
90
73
```
91
74
1. From the repository page in GitHub, click **New pull request**.
92
75
1. Select your working branch from the compare list.
93
-
1. Add `WIP:` to the title of the pull request. This automatically converts the pull request to a draft pull request.
76
+
1. Add `WIP:` to the title of the pull request. This automatically converts the pull request to a draft pull request, preventing it from being merged.
94
77
1. Click **Create new pull request**.
95
78
1. Add the **awaiting tech review** label to the pull request.
96
-
1. In the pull request comment field, enter `@redhataccess/eud-tech-review Please review for technical completeness and accuracy`.
97
-
79
+
1. In the pull request comment field, enter `@redhat-documentation/publishing-tutorial-team Please review for technical completeness and accuracy`.
98
80
99
81
### The review process
100
82
@@ -106,15 +88,11 @@ After creating and labeling a pull request as outlined above, the developers rev
106
88
When technical review is complete, writers click the **Reviewers** gear icon and selectthe name of a team member to request peer review. The peer writer reviews the pull request for clarity, consistency, and compliance with necessary standards.
107
89
Writers receive a notification that comments have been added via email, and when all comments have been addressed, the reviewer clicks **Review changes > Approve** from the **Files changed** tab of the pull request to approve the changes and the pull request.
108
90
109
-
#### Code review
110
-
111
-
For code pull requests, one or more developers review the pull request. A contributor submits a PR and uses Github's **Reviewers** gear icon to tag `@redhataccess/pantheon-developers`. A developer comments on the code, and discusses it with the submitter, before ultimately deciding to accept or reject the PR.
112
-
113
91
### Merging a pull request
114
92
115
93
When you have addressed all technical review and peer review comments, notify the developers to accept the pull request.
116
94
117
95
1. Remove `WIP` from the title of the pull request.
118
-
1. Click **Request Review** and enter `@redhataccess/pantheon-developers`.
96
+
1. Click **Request Review** and enter `@@redhat-documentation/publishing-tutorial-team`.
119
97
120
98
The developers check that the **Tech review complete** label has been added to the pull request and peer pull request approval provided, then accept it.
0 commit comments