moving mock into each individual test

Author: slorello89

redis_enterprise_prometheus/tests/conftest.py

@@ -1,6 +1,3 @@
-import os
-
-import mock
 import pytest
 
 from .support import ENDPOINT
@@ -20,17 +17,3 @@ def instance():
     return {"openmetrics_endpoint": ENDPOINT, "tags": ["instance"], "tls_verify": "false"}
 
 
-@pytest.fixture()
-def mock_http_response():
-    f_name = os.path.join(os.path.dirname(__file__), "data", "metrics.txt")
-    with open(f_name, "r") as f:
-        text_data = f.read()
-    with mock.patch(
-        "requests.get",
-        return_value=mock.MagicMock(
-            status_code=200,
-            iter_lines=lambda **kwargs: text_data.split("\n"),
-            headers={"Content-Type": "text/plain"},
-        ),
-    ):
-        yield

redis_enterprise_prometheus/tests/test_redis_enterprise_prometheus.py

@@ -1,3 +1,4 @@
+import os
 import ssl
 from copy import deepcopy
 from typing import Any, Callable, Dict  # noqa: F401
@@ -14,8 +15,16 @@
 ssl._create_default_https_context = ssl._create_unverified_context
 
 
-@pytest.mark.unit
+@pytest.mark.unit  
 def test_instance_additional_check(aggregator, dd_run_check, mock_http_response):
+    # Load test data
+    f_name = os.path.join(os.path.dirname(__file__), "data", "metrics.txt")
+    with open(f_name, "r") as f:
+        text_data = f.read()
+    
+    # Mock the HTTP response
+    mock_http_response(text_data, status_code=200, headers={"Content-Type": "text/plain"})
+    
     # add additional metric groups for validation
     additional_metric_groups = ["REDIS2.DISK", "REDIS2.REPLICATION", "REDIS2.SEARCH"]
     instance = deepcopy(INSTANCE)
@@ -37,6 +46,14 @@ def test_instance_additional_check(aggregator, dd_run_check, mock_http_response)
 
 @pytest.mark.unit
 def test_instance_all_additional_check(aggregator, dd_run_check, mock_http_response):
+    # Load test data
+    f_name = os.path.join(os.path.dirname(__file__), "data", "metrics.txt")
+    with open(f_name, "r") as f:
+        text_data = f.read()
+    
+    # Mock the HTTP response
+    mock_http_response(text_data, status_code=200, headers={"Content-Type": "text/plain"})
+    
     # add additional metric groups for validation
     additional_metric_groups = [
         "REDIS2.REPLICATION",
@@ -70,6 +87,14 @@ def test_instance_all_additional_check(aggregator, dd_run_check, mock_http_respo
 
 @pytest.mark.unit
 def test_instance_exclude_metrics(aggregator, dd_run_check, mock_http_response):
+    # Load test data
+    f_name = os.path.join(os.path.dirname(__file__), "data", "metrics.txt")
+    with open(f_name, "r") as f:
+        text_data = f.read()
+    
+    # Mock the HTTP response
+    mock_http_response(text_data, status_code=200, headers={"Content-Type": "text/plain"})
+    
     # validate exclude_metrics are not present in metrics
     exclude_metrics = ["endpoint_client_connections", "redis_server_up"]
     instance = deepcopy(INSTANCE)
@@ -90,6 +115,14 @@ def test_end_to_end():
 
 @pytest.mark.unit
 def test_instance_invalid_group_check(aggregator, dd_run_check, mock_http_response):
+    # Load test data
+    f_name = os.path.join(os.path.dirname(__file__), "data", "metrics.txt")
+    with open(f_name, "r") as f:
+        text_data = f.read()
+    
+    # Mock the HTTP response
+    mock_http_response(text_data, status_code=200, headers={"Content-Type": "text/plain"})
+    
     instance = deepcopy(INSTANCE)
     instance["metric_groups"] = ["redis.bogus", "redis.raft"]
 
@@ -105,6 +138,14 @@ def test_instance_invalid_group_check(aggregator, dd_run_check, mock_http_respon
 
 @pytest.mark.unit
 def test_invalid_instance(aggregator, dd_run_check, mock_http_response):
+    # Load test data
+    f_name = os.path.join(os.path.dirname(__file__), "data", "metrics.txt")
+    with open(f_name, "r") as f:
+        text_data = f.read()
+    
+    # Mock the HTTP response
+    mock_http_response(text_data, status_code=200, headers={"Content-Type": "text/plain"})
+    
     instance = deepcopy(ERSATZ_INSTANCE)
     instance.pop("openmetrics_endpoint")