feat(pool): Improve success rate of new connections #3518
+1,232
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l are likely done in async flow
- Fix BenchmarkWantConnQueue_Dequeue timeout issue by limiting pre-population - Use object pooling in BenchmarkWantConnQueue_Enqueue to reduce allocations - Optimize BenchmarkWantConnQueue_EnqueueDequeue with reusable wantConn pool - Prevent GitHub Actions benchmark failures due to excessive memory usage Before: BenchmarkWantConnQueue_Dequeue ran for 11+ minutes and was killed After: All benchmarks complete in ~8 seconds with consistent performance
|
@cyningsun thank you for opening this pr, looking forward to continuing the discussion. |
ndyakov
previously approved these changes
Oct 20, 2025
There was a problem hiding this comment.
@cyningsun Thank you for this contribution. I do think we can include it in the library, I do not see any issues with it at the moment.
ndyakov
changed the title
ndyakov
changed the title
ndyakov
approved these changes
Oct 22, 2025
There was a problem hiding this comment.
@cyningsun left a question regarding the pool balance, the rest looks good.
Comment on lines
+589
to
+591
| if w.tryDeliver(cn, nil) { | ||
| return | ||
| } |
There was a problem hiding this comment.
if putIdleConn returns here, p.freeTurn() won't be called
Comment on lines
+600
to
+601
| _ = cn.Close() | ||
| return |
There was a problem hiding this comment.
here as well, p.freeTurn() won't be called. We can argue it doesn't matter in this case anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR continues the work from the previously closed PR (based on #3418), which was automatically closed after its base branch was merged.
It implements a context pattern for connection creation to prevent premature cancellation caused by short-lived request timeouts, which previously led to connection pool instability under high concurrency.
Solution
Changes
References