Using Field from a different class causes the validator to wrongly assume there are multiple primary keys

[sherpya]

the code in RedisModel validate_primary_key wrongly assumes there are multiple primary keys:

            if getattr(field_info, "primary_key", None):
                primary_keys += 1

should really be:

            if getattr(field_info, "primary_key", None) is True:
                primary_keys += 1

because I'm getting PydanticUndefined sometimes instead of None

[slorello89]

Interesting, can you share some code where you see this error?

[sherpya]

from functools import partial

from sqlmodel import Field

NullableField = partial(Field, default=None, nullable=True)

class SomeModel(HashModel):
    somefield: str | None = NullableField()

[slorello89]

This isn't enough to reproduce the issue. Can you please provide a minimal reproduction of the issue.

[sherpya]

ok you need at least 2 fields of such type:

from functools import partial

import sqlmodel
from redis_om import HashModel

NullableField = partial(sqlmodel.Field, default=None, nullable=True)


class SomeModel(HashModel):
    somefield1: str | None = NullableField()
    somefield2: str | None = NullableField()


SomeModel()

[slorello89]

There's a conflict between sqlmodel and redis_om, they both have an attribute primary_key, which redis-om sets to False by default, where sqlmodel sets it to PydanticUndefinied. You can set it to False in your partial there and it should work:

NullableField = partial(sqlmodel.Field, default=None, nullable=True, primary_key=False)

[sherpya]

yes it is defined as:

primary_key: Union[bool, UndefinedType] = Undefined

but a check with is True would make more sense for the validator