Skip to content

Static fallback is stubbed — real implementation deferred #4

@redredchen01

Description

@redredchen01

Status

config.SUGGEST_STATIC_FALLBACK ships False. When flipped on, seoserper/suggest.py:_static_fallback returns an empty list — the real design (surface past OK rows from SQLite when upstream is down) is intentionally deferred.

Trigger criteria for implementing

Implement when ONE of these fires in real use:

  • Cache-miss rate on suggest_cache > 30% on a rolling 7-day window
  • Network outage or upstream Google Suggest block that lasts > 1 hour
  • Operator repeatedly hits ⚠️ degraded banner on a single session

Until then, the stub exists so the if config.SUGGEST_STATIC_FALLBACK branch is real code (not NotImplementedError) and static-path tests have something to call.

References

  • Plan: docs/plans/2026-04-20-007-feat-suggest-library-plan.md Unit 4
  • Grep: TODO(static-fallback) in seoserper/suggest.py

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions