Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical bug in the code #2

Open
yfeizhang opened this issue Feb 6, 2024 · 0 comments
Open

Logical bug in the code #2

yfeizhang opened this issue Feb 6, 2024 · 0 comments

Comments

@yfeizhang
Copy link

Hi folks, thanks for your excellent work!
I have used the repo and I found a very key bug in the following position.
Actually, in your model architecture, there is no layer called ".fc", therefore, directly replace to identity layer will not transfer the network architecture to embedder (actually not change the network architecture at all, just add another identity layer in the network class not to use). It is better to fix the bug in the repo.
https://github.com/ruoxi-jia-group/LAVA/blob/84e8bd55e62239625d8728240ec041d2fca5b2f4/lava.py#L88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant