#3957 - Validation routines for metaboxes not completely working.

Author: kprovance

redux-core/inc/classes/class-redux-validation.php

@@ -35,7 +35,6 @@ public function validate( array $plugin_options, array $options, array $sections
 			foreach ( $sections as $k => $section ) {
 				if ( isset( $section['fields'] ) ) {
 					foreach ( $section['fields'] as $fkey => $field ) {
-
 						if ( is_array( $field ) ) {
 							$field['section_id'] = $k;
 						}
@@ -220,20 +219,22 @@ public function validate( array $plugin_options, array $options, array $sections
 							$plugin_option = $plugin_options[ $field['id'] ] ?? null;
 							$option        = $options[ $field['id'] ] ?? null;
 
-							$callbackvalues = call_user_func( $callback, $field, $plugin_option, $option );
+							if ( null !== $plugin_option ) {
+								$callbackvalues = call_user_func( $callback, $field, $plugin_option, $option );
 
-							$plugin_options[ $field['id'] ] = $callbackvalues['value'];
+								$plugin_options[ $field['id'] ] = $callbackvalues['value'];
 
-							if ( isset( $callbackvalues['error'] ) ) {
-								$core->errors[] = $callbackvalues['error'];
-							}
+								if ( isset( $callbackvalues['error'] ) ) {
+									$core->errors[] = $callbackvalues['error'];
+								}
 
-							if ( isset( $callbackvalues['warning'] ) ) {
-								$core->warnings[] = $callbackvalues['warning'];
-							}
+								if ( isset( $callbackvalues['warning'] ) ) {
+									$core->warnings[] = $callbackvalues['warning'];
+								}
 
-							if ( isset( $callbackvalues['sanitize'] ) ) {
-								$core->sanitize[] = $callbackvalues['sanitize'];
+								if ( isset( $callbackvalues['sanitize'] ) ) {
+									$core->sanitize[] = $callbackvalues['sanitize'];
+								}
 							}
 						}
 					}

redux-core/inc/extensions/metaboxes/class-redux-extension-metaboxes.php

@@ -276,7 +276,7 @@ public function init() {
 
 			foreach ( $this->boxes as $bk => $box ) {
 
-				// If the post ids for this box are set, we're limiting to the current post id.
+				// If the post-ids for this box are set, we're limiting to the current post id.
 				if ( ! empty( $box['post_ids'] ) ) {
 					if ( ! is_array( $box['post_ids'] ) ) {
 						$box['post_ids'] = array( $box['post_ids'] );
@@ -287,7 +287,7 @@ public function init() {
 				}
 
 				if ( ! empty( $box['sections'] ) ) {
-					$this->sections = $box['sections'];
+					$this->sections = wp_parse_args( $this->sections, $box['sections'] );
 
 					$this->post_types = wp_parse_args( $this->post_types, $box['post_types'] );