Enforce type imports where applicable (#338)

Co-authored-by: Tim Dorr <[email protected]>

Author: mgol

.eslintrc

@@ -19,6 +19,7 @@
     "import/no-unresolved": "off",
     "import/named": "off",
     "@typescript-eslint/ban-ts-ignore": "off",
+    "@typescript-eslint/consistent-type-imports": ["error"],
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/member-delimiter-style": "off",

src/types.ts

@@ -1,4 +1,4 @@
-import { Action, AnyAction, Middleware } from 'redux'
+import type { Action, AnyAction, Middleware } from 'redux'
 
 /**
  * The dispatch method as modified by React-Thunk; overloaded so that you can

test/.eslintrc

@@ -4,6 +4,7 @@
   },
   "rules": {
     "@typescript-eslint/ban-ts-comment": "off",
+    "@typescript-eslint/consistent-type-imports": ["error"],
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/camelcase": "off",
     "@typescript-eslint/no-use-before-define": "off",

test/tsconfig.json

@@ -3,6 +3,7 @@
   "compilerOptions": {
     "module": "commonjs",
     "strict": true,
+    "importsNotUsedAsValues": "error",
     "target": "ES2015"
   },
   "include": ["**/*.ts"]

tsconfig.json

@@ -1,6 +1,7 @@
 {
   "compilerOptions": {
     "strict": true,
+    "importsNotUsedAsValues": "error",
     "target": "ESNext",
     "module": "ESNext",
     "moduleResolution": "Node",

typescript_test/.eslintrc

@@ -1,6 +1,7 @@
 {
   "rules": {
     "@typescript-eslint/ban-ts-comment": "off",
+    "@typescript-eslint/consistent-type-imports": ["error"],
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/camelcase": "off",
     "@typescript-eslint/no-unused-vars": "off",

typescript_test/tsconfig.json

@@ -2,6 +2,7 @@
   "compilerOptions": {
     "module": "commonjs",
     "strict": true,
+    "importsNotUsedAsValues": "error",
     "target": "ES2015"
   },
   "include": ["typescript.ts"]

typescript_test/typescript.ts

@@ -1,13 +1,9 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
-import {
-  applyMiddleware,
-  bindActionCreators,
-  createStore,
-  Action,
-  AnyAction
-} from 'redux'
-
-import thunk, {
+import { applyMiddleware, bindActionCreators, createStore } from 'redux'
+import type { Action, AnyAction } from 'redux'
+
+import thunk from '../src/index'
+import type {
   ThunkAction,
   ThunkActionDispatch,
   ThunkDispatch,

typescript_test/typescript_extended/extended-redux.ts

@@ -9,7 +9,8 @@ import {
   Dispatch
 } from 'redux'
 
-import thunk, {
+import thunk from '../../src/index'
+import type {
   ThunkAction,
   ThunkActionDispatch,
   ThunkDispatch,

typescript_test/typescript_extended/tsconfig.json

@@ -3,6 +3,7 @@
   "compilerOptions": {
     "module": "commonjs",
     "strict": true,
+    "importsNotUsedAsValues": "error",
     "target": "ES2015"
   },
   "include": ["extended-redux.ts"]