Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some buttons to insert control codes missing #7

Open
lippmaje opened this issue Dec 17, 2022 · 3 comments
Open

some buttons to insert control codes missing #7

lippmaje opened this issue Dec 17, 2022 · 3 comments

Comments

@lippmaje
Copy link

lippmaje commented Dec 17, 2022

There's a panel to insert control codes into strings (see below).
But there are no buttons to insert OVER on/off, or FLASH/BRIGHT/INVERSE/OVER/INK/PAPER 8, or INK/PAPER 9, or TAB/AT positions.
Also,

  • CAPS is a bit misleading as it inserts \006 which is the code for a tab (comma in prints).
  • EDIT inserts \007 which has no effect except placing a '?' on screen, so doesn't make sense to include unless you wanted to support all codes <32.
  • ENTER inserts a newline which immediately splits up the line in the editor. Speccy is unable to handle any newline (code \013) that is not occurring at the end of the program line. That means, the button here is completely useless.

The roll-over hint in the picture is also wrong, 'Cyan Ink = CHR$(29)' should read '...CHR$(16)+CHR$(5)'

Release: v1.792

Clipboard01

@ref-xx
Copy link
Owner

ref-xx commented Jan 30, 2023

about caps, edit and enter, check keypress column at https://en.wikipedia.org/wiki/ZX_Spectrum_character_set
they are for testing input
like if inkey$="[06]" then .... which corresponds to CAPS+2 = Caps Lock
I don't think any correcting is necessary in editing part of the window. Maybe CAPS/COMMA can be written.

Color codes needs some work yes, but they are absolutely hard to edit. I'll leave this issue here maybe somebody else could look into it and resolve it properly.

@lippmaje
Copy link
Author

lippmaje commented Jan 31, 2023

About Caps and Edit, yeah I didn't think of the input checks.
But Enter is pointless, if you try to insert an Enter into a string, the line will instantly split, syntax error. I suggest to remove this button.
Over on/off should be just two additional buttons in the box that place the code sequence \021\000 .. \021\001.
And another button row for Flash 8, Bright 8, Inverse 8, Over 8.
Likewise maybe Ink 8/9 and Paper 8/9.
It's a pain to hack these byte sequences into a string, because you have to save the program, edit it in a text editor and read it back into Basin in the hope it accepts the codes.
And AT is completely screwed, as someone else pointed out, because Basin tries to fix the \022 sequence in a bad way.

@ref-xx
Copy link
Owner

ref-xx commented May 21, 2024

I worked on token window a little bit, and it's not easy to fit anymore buttons there let alone four more control codes and AT control codes. it looks like it needs a good amount of effort to make it more useful. I'll added this to to-do list, but don't expect anything soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants