-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Will Remix-PWA support the move to React Router v7? #284
Comments
Remix PWA would support react router as well as Remix. React Router v7 is very similar to Remix, and my goal is to ensure wether you choose to use existing Remix versions, or new React router versions, Remix PWA would provide support for them |
Hi, thanks for the hard work here! Just curious if there is a timeline in mind? I tried remix-pwa v3 today and noticed that it was not compatible with react-router v7, because remix-pwa made assumption that As someone new to do this package, I would love to know whether v5 is almost ready, or should I give v4 a try? |
The docs also has a next section that's dedicated to v5, the docs aren't fully done yet tho. Regarding the timeline, I don't have one. React Router v7 is similar to Remix, but with a few distinctions that I need to explore |
Hey @ShafSpecs. Any movement on this? |
Yeah, it's been pretty slow and would be a dev release for a while, but I am working on this |
@ShafSpecs Is there a github branch i can try out for this? |
Not yet unfortunately, I am still trying to get React Router v7 to work on my machine |
Maybe I can help? Can you post the error? I have it working on a new react-router app, as well as upgraded a big remix application to it. |
This branch (v5-rc): https://github.com/remix-pwa/monorepo/tree/v5-rc/sandboxes/rr7 I re-worked the sandbox to contain remix spa apps, normal ssr apps and a react router v7 app. The Remix apps work, but React Router throws errors for some reason
|
Okay i got it working. Seems to be a problem with the sandbox being inside a workspace. Changes i made:
![]()
![]() I suspect that this problem exists only for npm workspaces since https://github.com/remix-run/react-router-templates uses pnpm which works. and I can tell from personal experience that yarn workspaces also work. Hope that points you in the right direction... |
Thanks for the fix @IgnisDa! Started work on |
Hi @ShafSpecs! Any updates on this issue? |
Yeah, I'm still working on the manor PR for react router. This update would support both Remix and React Router, and then a second release would be coming after to sunset Remix support. With project renaming and a few other bonuses |
Great to know. Thanks for the update! |
I know it's not easy to do, but do you have any ballpark estimates on release date? |
I'm currently pretty slow 😅, but once I clear one of my freelance works (planning to wrap that up this month), I can slot this full time into my schedule |
If there is something i (or we) can help with, let me (us) know. |
Thanks for the offer! Currently, one of the last things remaining is lots of testing. I can push to dev later today, so it's available and you can start using (and testing real-time) on your end 👌. Most of the apis are the same, just a few changes |
Merged the first major change, I would be pushing more fixes and features in time |
Before I go update the docs, I would push the current changes to Create a new release for react-router-pwa, remove Remix support and then go revamp the docs. Sounds good? |
Yep that sounds like a good plan. Maybe also a canary release on npm so
that users can try it out and help you iron out the rough edges?
…On Sun, Mar 2, 2025, 5:00 PM Abdur-Rahman ***@***.***> wrote:
Before I go update the docs, I would push the current changes to latest.
Create a new release for react-router-pwa, remove Remix support and then
go revamp the docs. Sounds good?
—
Reply to this email directly, view it on GitHub
<#284 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQ5PNADIQBZRJ6SSZX6TAL2SLTVRAVCNFSM6AAAAABSYTHTVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSGY4DMOBYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: ShafSpecs]*ShafSpecs* left a comment (remix-pwa/monorepo#284)
<#284 (comment)>
Before I go update the docs, I would push the current changes to latest.
Create a new release for react-router-pwa, remove Remix support and then
go revamp the docs. Sounds good?
—
Reply to this email directly, view it on GitHub
<#284 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQ5PNADIQBZRJ6SSZX6TAL2SLTVRAVCNFSM6AAAAABSYTHTVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSGY4DMOBYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The canary release is out (via the |
This is awesome work, truly -- the most immediate thing coming up in testing for me is
|
I would need to fix that ASAP. Thx for the heads up |
To add, I also get this error while building the project:
This is probably due to the usage of |
Look forward to trying this, we want to make the switch. |
Opened a new PR, still making sure I don't nuke anyone's project. This PR fully sunsets Remix support fully (as dual support had so many issues) |
React Router PWA v5 vs React Router PWA v1? |
Do you plan to rename the project to react-router-pwa? I see the package is free on npm (https://www.npmjs.com/package/react-router-pwa). If you do plan to rename, i recommend pushing a few dummy files to that package so that it is not claimed. |
I'd personally prefer v1 since the new project targets react-router and not remix. so its a new project IMO. |
Yes, keeping the name Remix PWA becomes confusing in the long run. I'm also debating renaming the org or just creating another and archiving the code here. The first is the easiest, the second allows for legacy support |
any update on this? eager to give it a try in my rr7 project |
@sjbuysse, please see @ShafSpecs's #284 (comment):
So yes, give it a try and provide feedback if you can. |
@ShafSpecs were you able to arrive on a decision for this? |
Yep, I would try and lock down the package today. Irl is super busy at the moment. Currently getting ready to head out to the airport lol So please, forgive my tardiness |
Oh no, please always prioritize your life first! Thanks for the update. |
Hi,
This seems like a great package. However, it seems Remix is "taking a pause" now that all the functionality has moved to React Router v7:
Will Remix-PWA publish future versions based around React Router v7 instead of Remix?
Thanks!
The text was updated successfully, but these errors were encountered: