Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up #866 #928

Open
dc-mak opened this issue Mar 10, 2025 · 1 comment
Open

Tidy up #866 #928

dc-mak opened this issue Mar 10, 2025 · 1 comment
Assignees
@yav
Labels
technical debt Something for internal cleanup

Comments

@dc-mak
Copy link
Collaborator

dc-mak commented Mar 10, 2025 

          Thanks for the extra documentation comments in the code! And for doing this fiddly piece of work, and getting this merged in. If you are able to address the comments in follow-up PRs, that would be much appreciated!

Also if the commit messages in the future could follow the guidelines stated here, that would be great too: https://cbea.ms/git-commit/#seven-rules

Specifically, 50 chars for the header and a short explanation.

Originally posted by @dc-mak in #866 (review)
@dc-mak dc-mak added the technical debt Something for internal cleanup label Mar 10, 2025
@yav
Copy link
Collaborator

yav commented Mar 10, 2025

Thanks for the review. I'll post my thoughts on the suggested changes in the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yav yav

Labels
technical debt Something for internal cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yav @dc-mak