f

Author: emosbaugh

pkg/addons/registry/migrate/job.go

@@ -196,6 +196,14 @@ func isJobRetrying(ctx context.Context, cli client.Client) (bool, error) {
 	if err != nil {
 		return false, fmt.Errorf("get job: %w", err)
 	}
+	if job.Status.Succeeded >= 1 {
+		// job is successful
+		return false, nil
+	}
+	if job.Status.Failed == 0 {
+		// job has not yet tried
+		return false, nil
+	}
 	exceedsBackoffLimit := job.Status.Failed > *job.Spec.BackoffLimit
 	return !exceedsBackoffLimit, nil
 }

pkg/addons/registry/migrate/job_test.go

@@ -2,8 +2,11 @@ package migrate
 
 import (
 	"bytes"
+	"context"
 	"log/slog"
 	"testing"
+
+	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
 func Test_isProgressLogLine(t *testing.T) {
@@ -39,3 +42,30 @@ func Test_getProgressFromLogLine(t *testing.T) {
 	}
 	buf.Reset()
 }
+
+func Test_isJobRetrying(t *testing.T) {
+	type args struct {
+		ctx context.Context
+		cli client.Client
+	}
+	tests := []struct {
+		name    string
+		args    args
+		want    bool
+		wantErr bool
+	}{
+		// TODO: Add test cases.
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := isJobRetrying(tt.args.ctx, tt.args.cli)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("isJobRetrying() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if got != tt.want {
+				t.Errorf("isJobRetrying() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}