Skip to content

Commit b785c5c

Browse files
Some reverts
1 parent 4f9633c commit b785c5c

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

packages/@rescript/runtime/Stdlib_Intl_DateTimeFormat.res

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,17 @@ type formatMatcher = [#basic | #"best fit"]
3535
type fractionalSecondDigits = [#0 | #1 | #2 | #3]
3636

3737
type options = {
38-
dateStyle?: dateStyle,
39-
timeStyle?: timeStyle,
38+
dateStyle?: dateStyle, // can be used with timeStyle, but not other options
39+
timeStyle?: timeStyle, // can be used with dateStyle, but not other options
4040
calendar?: Stdlib_Intl_Common.calendar,
41-
dayPeriod?: dayPeriod,
41+
dayPeriod?: dayPeriod, // only has an effect if a 12-hour clock is used
4242
numberingSystem?: Stdlib_Intl_Common.numberingSystem,
4343
localeMatcher?: Stdlib_Intl_Common.localeMatcher,
4444
timeZone?: string,
4545
hour12?: bool,
4646
hourCycle?: hourCycle,
4747
formatMatcher?: formatMatcher,
48+
// date-time components
4849
weekday?: weekday,
4950
era?: era,
5051
year?: year,

packages/@rescript/runtime/Stdlib_Intl_Segments.res

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
/***
22
Bindings to `Segments` objects produced by `Intl.Segmenter.segment`.
3+
A Segments instance is an object that represents the segments of a specific string, subject to the locale and options of its constructing Intl.Segmenter instance.
4+
https://tc39.es/ecma402/#sec-segments-objects.
35
46
See [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/segment) for API details and the [ECMA-402 specification](https://tc39.es/ecma402/#sec-segments-objects) for the object shape.
57
*/

packages/@rescript/runtime/Stdlib_WeakMap.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ See [`WeakMap.prototype.has`](https://developer.mozilla.org/en-US/docs/Web/JavaS
5050
let cache = Stdlib_WeakMap.make()
5151
let key = Stdlib_Object.make()
5252
Stdlib_WeakMap.has(cache, key) == false
53-
let _ = Stdlib_WeakMap.set(cache, key)
53+
let _ = Stdlib_WeakMap.set(cache, key, ())
5454
Stdlib_WeakMap.has(cache, key) == true
5555
```
5656
*/

0 commit comments

Comments
 (0)