Skip to content

Commit 7b734fa

Browse files
authored
Merge pull request #54 from retejs/ci-change-react-builder
React vite
2 parents 96338d0 + 8ea30ee commit 7b734fa

File tree

6 files changed

+11
-10
lines changed

6 files changed

+11
-10
lines changed

.github/workflows/daily.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
version: [18,17,16]
2727
uses: ./.github/workflows/regression.yml
2828
with:
29-
name: react
29+
name: react-vite
3030
version: ${{ matrix.version }}
3131
node: 18
3232

.github/workflows/regression.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ on:
2929
description: Stack
3030
options:
3131
- react
32+
- react-vite
3233
- vue
3334
- angular
3435
- svelte

package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"globals": "^15.9.0",
3333
"nodemon": "^2.0.20",
3434
"rete-cli": "~2.0.1",
35-
"rete-kit": "^1.10.0",
35+
"rete-kit": "^1.10.2",
3636
"typescript": "^4.9.5"
3737
},
3838
"peerDependencies": {

src/commands/init/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { App } from 'rete-kit'
22

33
export const targets: { stack: App.AppStack, versions: number[] }[] = [
44
{ stack: 'react', versions: [16, 17, 18] },
5+
{ stack: 'react-vite', versions: [16, 17, 18] },
56
{ stack: 'vue', versions: [2, 3] },
67
{ stack: 'angular', versions: [12, 13, 14, 15, 16, 17, 18] },
78
{ stack: 'svelte', versions: [3, 4] },
@@ -21,7 +22,7 @@ export const fixtures = targets
2122
export function getFeatures({ stack, version }: Pick<(typeof fixtures)[0], 'stack' | 'version'>, next: boolean) {
2223
return [
2324
stack === 'angular' && new App.Features.Angular(version as 12 | 13 | 14 | 15 | 16 | 17 | 18, next),
24-
stack === 'react' && new App.Features.React(version, stack, next),
25+
['react', 'react-vite'].includes(stack) && new App.Features.React(version, stack, next),
2526
stack === 'vue' && new App.Features.Vue(version as 2 | 3, next),
2627
stack === 'svelte' && new App.Features.Svelte(version as 3 | 4, next),
2728
stack === 'lit-vite' && new App.Features.Lit(version as 3, next),

src/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ program
2424
.option('-s --stack <stack>', `Stacks to test, comma-separated (${stackNames.join(',')})`)
2525
.option('-sv --stack-versions <stack-version>', `Versions to test, comma-separated`)
2626
.action(async (options: { depsAlias: string, stack?: string, stackVersions?: string, next?: boolean }) => {
27-
if (!process.version.startsWith('v16')) console.info(chalk.yellow('---\nWe recommend using Node.js 16 to avoid any potential issues\n---'))
28-
2927
const next = options.next || false
3028
const cwd = process.cwd()
3129
const depsAlias = options.depsAlias
@@ -130,6 +128,7 @@ program
130128
log('success', 'START')('Testing in', chalk.yellow(folder), '...')
131129
const APP = folder
132130
const SERVE = App.builders[stack].getStaticPath(folder, version)
131+
console.log({ SERVE })
133132
const playwrightFolder = dirname(require.resolve('@playwright/test'))
134133

135134
const { error } = await validateTestRun(APP, SERVE)

0 commit comments

Comments
 (0)