Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drum notations are not supported #4

Open
ghost opened this issue Aug 6, 2015 · 3 comments
Open

Drum notations are not supported #4

ghost opened this issue Aug 6, 2015 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 6, 2015

Most drum notation software use MusicXML as output format, it would be nice if vexflow could handle drum glyphs.

@ringw
Copy link
Owner

ringw commented Aug 6, 2015

If drum glyphs are added to the upstream VexFlow, I could add MusicXML parsing support for them. As far as I know, they are not currently available. If you don't mind, please open an issue at https://github.com/0xfe/vexflow.

ringw added a commit that referenced this issue Aug 6, 2015
@ringw
Copy link
Owner

ringw commented Aug 6, 2015

I've just added percussion clef support to the MusicXML parser. I think the remaining steps are to add the "x" note glyph and any other custom glyphs, and then I will also need to add support for those in MusicXML.

@ghost
Copy link
Author

ghost commented Aug 8, 2015

Actually, I took a look at Vexflow source code, and percussions are partially handled. You can find some example in the /test/test_percussions.js file. Yet, they don't seem to be implemented in VexTab (or I don't know what I should write to display them), hence my confusion. Moreover, the chosen symbols are not standard.

I will take a look at your modifcation, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant