From 80c1f206c404c836573efde4e37b3978db1a47d3 Mon Sep 17 00:00:00 2001 From: jog1t <39823706+jog1t@users.noreply.github.com> Date: Wed, 1 Oct 2025 17:55:26 +0000 Subject: [PATCH] fix(cf-workers): add missing function (#1324) Fixes #1323 ### TL;DR Added `getOrCreateInspectorAccessToken` implementation to CloudflareActorsManagerDriver and exported the `generateRandomString` utility. ### What changed? - Implemented the `getOrCreateInspectorAccessToken` method in the CloudflareActorsManagerDriver class, which returns a randomly generated string - Imported `generateRandomString` in the manager-driver.ts file - Exported `generateRandomString` from the driver-helpers module - Changed the JSDoc annotation for `getOrCreateInspectorAccessToken` from `@internal` to `@experimental` ### How to test? 1. Verify that the CloudflareActorsManagerDriver correctly implements the ManagerDriver interface 2. Test that `getOrCreateInspectorAccessToken()` returns a random string when called 3. Confirm that `generateRandomString` can be imported from the driver-helpers module ### Why make this change? This change completes the implementation of the ManagerDriver interface in the CloudflareActorsManagerDriver class by adding the missing `getOrCreateInspectorAccessToken` method. The method is marked as experimental, indicating it's available for use but the API might change in future versions. Exporting the `generateRandomString` utility makes it available for other components that need to generate random strings. --- packages/cloudflare-workers/src/manager-driver.ts | 5 +++++ packages/rivetkit/src/driver-helpers/mod.ts | 1 + packages/rivetkit/src/manager/driver.ts | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/cloudflare-workers/src/manager-driver.ts b/packages/cloudflare-workers/src/manager-driver.ts index 6948e3858..f7905e1aa 100644 --- a/packages/cloudflare-workers/src/manager-driver.ts +++ b/packages/cloudflare-workers/src/manager-driver.ts @@ -6,6 +6,7 @@ import { type GetForIdInput, type GetOrCreateWithKeyInput, type GetWithKeyInput, + generateRandomString, type ManagerDisplayInformation, type ManagerDriver, WS_PROTOCOL_ACTOR, @@ -372,4 +373,8 @@ export class CloudflareActorsManagerDriver implements ManagerDriver { properties: {}, }; } + + getOrCreateInspectorAccessToken() { + return generateRandomString(); + } } diff --git a/packages/rivetkit/src/driver-helpers/mod.ts b/packages/rivetkit/src/driver-helpers/mod.ts index b37cb203c..e98c899fa 100644 --- a/packages/rivetkit/src/driver-helpers/mod.ts +++ b/packages/rivetkit/src/driver-helpers/mod.ts @@ -1,5 +1,6 @@ export type { ActorDriver } from "@/actor/driver"; export type { ActorInstance, AnyActorInstance } from "@/actor/instance"; +export { generateRandomString } from "@/actor/utils"; export { ALLOWED_PUBLIC_HEADERS, HEADER_ACTOR_ID, diff --git a/packages/rivetkit/src/manager/driver.ts b/packages/rivetkit/src/manager/driver.ts index 607fc570d..4c72ad004 100644 --- a/packages/rivetkit/src/manager/driver.ts +++ b/packages/rivetkit/src/manager/driver.ts @@ -52,7 +52,7 @@ export interface ManagerDriver { /** * Get or create the inspector access token. - * @internal + * @experimental * @returns creates or returns existing inspector access token */ getOrCreateInspectorAccessToken: () => string;