diff --git a/engine/packages/epoxy/src/ops/propose.rs b/engine/packages/epoxy/src/ops/propose.rs index 87e05f278f..08397940b5 100644 --- a/engine/packages/epoxy/src/ops/propose.rs +++ b/engine/packages/epoxy/src/ops/propose.rs @@ -356,6 +356,7 @@ async fn purge_optimistic_cache(ctx: OperationCtx, keys: Vec) -> Result< .workflow(crate::workflows::purger::Input { replica_id: dc.datacenter_label as u64, }) + .bypass_signal_from_workflow_I_KNOW_WHAT_IM_DOING() .tag("replica_id", dc.datacenter_label as u64) .unique() .dispatch() diff --git a/engine/packages/gasoline/src/builder/common/workflow.rs b/engine/packages/gasoline/src/builder/common/workflow.rs index f8404df9ac..6699e9c0e4 100644 --- a/engine/packages/gasoline/src/builder/common/workflow.rs +++ b/engine/packages/gasoline/src/builder/common/workflow.rs @@ -50,6 +50,17 @@ where } } + // TODO: Get rid of this (RVT-5281) + // NOTE: This is a bad implementation because it disregards other errors that may have happened earlier + #[allow(non_snake_case)] + pub fn bypass_signal_from_workflow_I_KNOW_WHAT_IM_DOING(mut self) -> Self { + if let Some(BuilderError::CannotDispatchFromOpInWorkflow) = &self.error { + self.error = None; + } + + self + } + pub fn tags(mut self, tags: serde_json::Value) -> Self { if self.error.is_some() { return self; diff --git a/engine/packages/guard-core/src/server.rs b/engine/packages/guard-core/src/server.rs index b9b591a7fc..59c16b1d3a 100644 --- a/engine/packages/guard-core/src/server.rs +++ b/engine/packages/guard-core/src/server.rs @@ -112,7 +112,7 @@ pub async fn run_server( tokio::spawn( async move { if let Err(err) = conn.await { - tracing::error!("{} connection error: {}", port_type_str, err); + tracing::warn!("{} connection error: {}", port_type_str, err); } tracing::debug!("{} connection dropped: {}", port_type_str, remote_addr); diff --git a/engine/packages/pegboard/src/workflows/serverless/receiver.rs b/engine/packages/pegboard/src/workflows/serverless/receiver.rs index e3c3dcbec8..6f0af7bc16 100644 --- a/engine/packages/pegboard/src/workflows/serverless/receiver.rs +++ b/engine/packages/pegboard/src/workflows/serverless/receiver.rs @@ -33,6 +33,8 @@ pub async fn pegboard_serverless_receiver(ctx: &mut WorkflowCtx, input: &Input) namespace_id: input.namespace_id, runner_name: input.runner_name.clone(), }) + .tag("namespace_id", input.namespace_id) + .tag("runner_name", input.runner_name.clone()) .dispatch() .await?; diff --git a/engine/packages/pools/src/db/ups.rs b/engine/packages/pools/src/db/ups.rs index 9d098c2bf9..b10a4faa75 100644 --- a/engine/packages/pools/src/db/ups.rs +++ b/engine/packages/pools/src/db/ups.rs @@ -53,7 +53,8 @@ pub async fn setup(config: &Config, client_name: &str) -> Result { tracing::warn!(?server_addrs, "nats draining"); } async_nats::Event::Closed => { - tracing::error!(?server_addrs, "nats closed"); + // Engine is shutting down, not an error + tracing::info!(?server_addrs, "nats closed"); } async_nats::Event::SlowConsumer(sid) => { tracing::warn!(?server_addrs, ?sid, "nats slow consumer"); diff --git a/engine/packages/runtime/src/traces.rs b/engine/packages/runtime/src/traces.rs index d07c4155cb..2f0103696a 100644 --- a/engine/packages/runtime/src/traces.rs +++ b/engine/packages/runtime/src/traces.rs @@ -118,6 +118,7 @@ fn build_filter_from_spec(filter_spec: &str) -> anyhow::Result { .add_directive("info".parse()?) // Disable verbose logs .add_directive("tokio_cron_scheduler=warn".parse()?) + .add_directive("async_nats=warn".parse()?) .add_directive("tokio=warn".parse()?) .add_directive("hyper=warn".parse()?) .add_directive("h2=warn".parse()?);