Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a column for each field specified in the fields parameter #77

Open
ledell opened this issue Oct 20, 2020 · 2 comments
Open

Comments

@ledell
Copy link
Member

ledell commented Oct 20, 2020

The PR which was just merged which adds the fields parameter to find_groups() will add the extra fields to the list (raw data), but the user still has to extract those fields and add them as extra columns to the returned tibble. Should we just add those fields automatically as columns, since it's almost 100% likely that the user will want to do that anyway, since they are explicitly requesting that data?

The other thing I was considering, if we do this, is to make the fields parameter more generic (possibly rename to extra_fields) and then we could allow the user to specify which extra fields they want to add to the returned tibble as extra columns. In this case, those fields could just be extra ones that we already have in the default resource raw list object but are not exposed as columns by default, or they could be the extra ones that must be passed via the API "fields" parameter to the /find/groups endpoint.

Lastly, since it seems like a lot of the endpoints support the "fields" parameter, we could consider adding this functionality to all of the functions. e.g. get_members()

@ledell
Copy link
Member Author

ledell commented Oct 20, 2020

If you have thoughts on this @benubah @RickPack please let me know!

@maelle
Copy link
Contributor

maelle commented Mar 22, 2021

Making the extra fields columns sounds like a good diea to me.

@ledell could you actually open one issue for each of your good ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants