Update 2.0.0 appears to break for POROs

[cjhutchi]

I recently updated to the latest version (2.0.0), and in our app we use this gem on some POROs. Here's an example of how we use it:

class PatientForm
  include ActiveModel::Model
  include ActiveModel::Attributes
  include ActiveModel::Validations::Callbacks

  strip_attributes only: :last_name, collapse_spaces: true

  ...
end

After the update, the callback to collapse_spaces seemed to break with this error:

undefined method '[]=' for an instance of PatientForm

I was able to fix it by manually just defining the [] and []= methods on the model

class PatientForm
  include ActiveModel::Model
  include ActiveModel::Attributes
  include ActiveModel::Validations::Callbacks

  strip_attributes only: :last_name, collapse_spaces: true

  def [](key)
    send(key)
  end

  def []=(key, value)
    send("#{key}=", value)
  end
  ...
end

Is this an actual bug in the release, or are the callbacks not intended to be used with objects that don't get persisted to the database like this and we should use the gem directly instead?

[rmm5t]

@cjhutchi Are you saying that things worked for you prior to v2.0.0 and they no longer work? I'm a little confused why that would be the case, because nothing changed between 1.x and 2.0 that would affect that exact scenario.
https://github.com/rmm5t/strip_attributes/compare/v1.14.1..v2.0.0

Officially, strip_attributes doesn't have any direct tests for the exact scenario you're working under.

There is an open PR (#66) to better support raw ActiveModel and I would like to incorporate that, but not at the expense of losing ActiveAttr.

[cjhutchi]

@rmm5t Sorry, yes, this was working prior to v2.0.0. We have a workaround for this, so its not a huge issue, I just wanted to bring it to your attention. Thanks for the quick response!

[justinko]

value.dup is the cause of the regression: https://github.com/rmm5t/strip_attributes/pull/80/files#diff-d6d7fbebc68691eb492b2d3dff74c7841e33653fe5aae5f5f44efc99905cc5a5R64