Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential typo in lambert.m #4

Open
cadojo opened this issue Apr 27, 2021 · 0 comments
Open

Potential typo in lambert.m #4

cadojo opened this issue Apr 27, 2021 · 0 comments

Comments

@cadojo
Copy link

cadojo commented Apr 27, 2021

On line 627 of lambert.m, should r1vec be listed as an argument twice? It seems like the third argument to minmax_distances should instead be r2vec.

Current Code

    extremal_distances = minmax_distances(r1vec, r1, r1vec, r2, dth, a, V1, V2, m, muC);

Proposed

    extremal_distances = minmax_distances(r1vec, r1, r2vec, r2, dth, a, V1, V2, m, muC);

Also, for your awareness, I've ported these functions to Julia over here. I followed the instructions in the BSD license listed to properly show credit, etc. Please let me know if you have any questions.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant