Skip to content

Commit 38bae62

Browse files
authored
Merge pull request #130 from nolantait/rails-7-nt
Rails 7
2 parents 03126f1 + 89b352f commit 38bae62

File tree

9 files changed

+18
-15
lines changed

9 files changed

+18
-15
lines changed

Gemfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ source 'https://rubygems.org'
22

33
gemspec
44

5-
RAILS_VERSION = ENV.fetch("RAILS_VERSION", '6.1.1').freeze
5+
RAILS_VERSION = ENV.fetch("RAILS_VERSION", '7.0.4').freeze
66

77
%w(railties actionview actionpack activerecord).each do |name|
88
gem name, "~> #{RAILS_VERSION}"
@@ -11,8 +11,6 @@ end
1111
gem 'byebug', platforms: :mri
1212
gem 'sqlite3', platforms: [:mri, :rbx]
1313

14-
15-
1614
if ENV["USE_ROM_MASTER"].eql?("true")
1715
gem 'rom', git: 'https://github.com/rom-rb/rom', branch: 'master' do
1816
gem 'rom-core'
@@ -33,6 +31,7 @@ platforms :jruby do
3331
end
3432

3533
group :test do
34+
gem 'debug'
3635
gem 'capybara'
3736
gem 'codeclimate-test-reporter', require: nil
3837
gem 'database_cleaner', "~> 1.8.1"

lib/generators/rom/install/templates/application_model.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
require "types"
2+
require "dry/core/equalizer"
23

34
class ApplicationModel < ROM::Struct
45
def self.inherited(base)
@@ -9,7 +10,7 @@ def self.inherited(base)
910
base.extend ActiveModel::Naming
1011
base.include ActiveModel::Conversion
1112

12-
base.include Dry::Equalizer(:id)
13+
base.include Dry::Core::Equalizer.new(:id)
1314

1415
base.attribute :id, Types::ID
1516
end

lib/rom/rails/active_record/configuration.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ def initialize(env: ::Rails.env, root: ::Rails.root, configurations: ::ActiveRec
3737
#
3838
# @api private
3939
def call
40-
specs = { default: build(default_configuration.symbolize_keys) }
40+
specs = { default: build(default_configuration.configuration_hash) }
4141

4242
if rails6?
4343
configurations.configs_for(env_name: env).each do |config|
44-
specs[config.spec_name.to_sym] = build(config.config.symbolize_keys)
44+
specs[config.name.to_sym] = build(config.configuration_hash)
4545
end
4646
end
4747

@@ -50,7 +50,7 @@ def call
5050

5151
def default_configuration
5252
if rails6?
53-
configurations.default_hash(env)
53+
configurations.configs_for(env_name: env).first
5454
else
5555
configurations.fetch(env)
5656
end

rom-rails.gemspec

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@ Gem::Specification.new do |spec|
2323
}
2424

2525
spec.add_runtime_dependency 'addressable', '~> 2.3'
26-
spec.add_runtime_dependency 'dry-core', '~> 0.4'
27-
spec.add_runtime_dependency 'dry-equalizer', '~> 0.2'
28-
spec.add_runtime_dependency 'railties', '>= 3.0', '< 6.2'
29-
spec.add_runtime_dependency 'rom', '~> 5.2'
26+
spec.add_runtime_dependency 'dry-core', '~> 1.0'
27+
spec.add_runtime_dependency 'railties', '>= 3.0', '<= 7.0.4'
28+
spec.add_runtime_dependency 'rom', '~> 5.3'
3029

3130
spec.add_development_dependency "bundler"
3231
spec.add_development_dependency "rake"

spec/dummy/app/models/user.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
class User
2-
include Dry::Equalizer(:id, :name, :email)
2+
include Dry::Core::Equalizer.new(:id, :name, :email)
33

44
attr_reader :id, :name, :email
55

spec/dummy/config/application.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
require 'rom-sql'
88
require 'rom-rails'
99
require 'rspec-rails'
10+
require 'dry/core/equalizer'
1011

1112
module Dummy
1213
class Application < Rails::Application

spec/dummy/lib/rom/test_adapter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ class Relation < ROM::Relation
55
end
66

77
class Gateway < ROM::Gateway
8-
include Dry::Equalizer(:args)
8+
include Dry::Core::Equalizer.new(:args)
99
adapter :test_adapter
1010

1111
attr_reader :args, :datasets

spec/lib/active_record/configuration_spec.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ def parse(uri)
2020
URI.parse(uri.gsub(/^jdbc:/, ''))
2121
end
2222

23-
it 'raises an error without specifying a database'
23+
it 'raises an error without specifying a database' do
24+
expect { read({}) }.to raise_error KeyError
25+
end
2426

2527
context 'with postgresql adapter' do
2628
it 'rewrites the scheme' do

spec/lib/generators/install_generator_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ module Types
6464
file "application_model.rb" do
6565
contains <<-CONTENT.strip_heredoc
6666
require "types"
67+
require "dry/core/equalizer"
6768
6869
class ApplicationModel < ROM::Struct
6970
def self.inherited(base)
@@ -74,7 +75,7 @@ def self.inherited(base)
7475
base.extend ActiveModel::Naming
7576
base.include ActiveModel::Conversion
7677
77-
base.include Dry::Equalizer(:id)
78+
base.include Dry::Core::Equalizer.new(:id)
7879
7980
base.attribute :id, Types::ID
8081
end

0 commit comments

Comments
 (0)