The to-do list

[rootm0s]

The to-do list:

• Update all the "print_" messages so they make more sense
• Update all function descriptions so they are correct
• Update README
• A better way to do cleanup. Right now.. if function returns False in early stage, this prevents the cleanup in most of the functions. (Fixed in: f8dd0a6)
• Restructure winstructures, it's all messy right now
• Convert the code to python3 but keep python2 support so Pupy (https://github.com/n1nj4sec/pupy) can work
• Add automated testing (Travis CI, AppVeyor, etc.)
• Replace all sys.argv[] calls from main.py and use argparse instead (Fixed in: 7de4146)
• Deprecate py2exe support
• Remove py2exe from README
• Add better way to display the scan results
• Change Syntax winpwnage.py in README to main.py
• Deprecate DLL based methods/functions
• Remove Python2 support

[cclauss]

• Add automated testing (CircleCI, Travis CI, AppVeyor, etc.)?

[rootm0s]

• Add automated testing (CircleCI, Travis CI, AppVeyor, etc.)?

I do all the testing manually at the moment. I don't use any of those since there's no version-handling on this project. Is it simular to unittest?

[cclauss]

These are automated tools that test each pull request before it is reviewed. One of the tests that they could run could be unittests. They could also run other test frameworks (pytest) and linters (pylint, flake8, mypy, etc).

CPython runs several (click Show all checks):

• bpo-36366: Return None on stopping unstarted patch object python/cpython#12472 (comment)

[rootm0s]

Alright, thanks for the info. I'll add it to the todo!

[rootm0s]

Followed your steps and merged the PR @cclauss - let me know if I missed something, im new to Travis Ci.

[cclauss]

Tests are running now... #23

[rootm0s]

Merged #23 as well

[cclauss]

Nice work! So the rule going forward should be: If Travis is not green, the PR should not be merged.

[cclauss]

You can check the last box in the list above.

[rootm0s]

Nice work! So the rule going forward should be: If Travis is not green, the PR should not be merged.

Alright, good to know. Thanks!

You can check the last box in the list above.

Done!

[cclauss]

Is it time to check the second last box above?