Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all label sequences are automated #104

Closed
5 of 7 tasks
mpadge opened this issue Jan 26, 2024 · 8 comments
Closed
5 of 7 tasks

Ensure all label sequences are automated #104

mpadge opened this issue Jan 26, 2024 · 8 comments

Comments

@mpadge
Copy link
Collaborator

mpadge commented Jan 26, 2024

This is the more general issue behind #102 and #103. Our labels are:








And we have the following transitions in our config/settings-production.yml:

So we're missing two stages in our automation:

  • Initially adding
  • ➡️

Comments please @maelle @noamross. In particular, it seems the following questions need answering:

  1. What command or automation step could/should we use to automatically add ? Should we detect that checks are okay, and auto-add label then?
  2. What command should we add to transition 4\ ➡️ 5\? Should it be able to be issued by both editor and author?
@maelle
Copy link
Collaborator

maelle commented Jan 30, 2024

What command should we add to transition 4\ ➡️ 5? Should it be able to be issued by both editor and author?

Shouldn't it be

ropensci_submit_author_response:
?

@mpadge
Copy link
Collaborator Author

mpadge commented Jan 30, 2024

Yes, i guess so ❓ Trick there would be that those are individual responses, and there is no equivalent of this:

label_when_all_reviews_in: "4/review(s)-in-awaiting-changes"
unlabel_when_all_reviews_in: "3/reviewer(s)-assigned"

that is, no way of identifying an all_responses_in event...

@maelle
Copy link
Collaborator

maelle commented Jan 30, 2024

this is a responder for the author to indicate where the response is. Only one such response is expected.

@mpadge
Copy link
Collaborator Author

mpadge commented Jan 30, 2024

Okay, then that would indeed be the place. Do you want to update #103 with that change?

@maelle
Copy link
Collaborator

maelle commented Jan 30, 2024

That's what #103 does?

@mpadge
Copy link
Collaborator Author

mpadge commented Jan 30, 2024

Aha - 💡 goes on in my 🧠 ❗ ... then the only remaining problem is that it is not a proper transition. The good news for me is that it means this issue was still worthwhile. And what I think i now need to ask you to do is also:

add_labels:
  - 5/awaiting-reviewer(s)-responses

Right ❓

@maelle
Copy link
Collaborator

maelle commented Feb 1, 2024

Right!

@mpadge
Copy link
Collaborator Author

mpadge commented Jun 21, 2024

@maelle Just cleaning out some issues, including closing this one which I think is okay now.

@mpadge mpadge closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants