Skip to content

footnotes #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

footnotes #97

wants to merge 1 commit into from

Conversation

maelle
Copy link
Member

@maelle maelle commented Nov 20, 2020

Fix #7 -- In the future if there is a Markdown render hook for footnotes, we can switch to using bootstrap for this.

PR in roweb3-styles adding the littlefoot npm package https://github.com/ropensci-org/roweb3-styles/pull/3 (to get the CSS)

@maelle maelle requested a review from jeroen November 20, 2020 11:45
@maelle
Copy link
Member Author

maelle commented Nov 30, 2020

👋 @jeroen

Copy link
Member

@stefaniebutland stefaniebutland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the preview I don't see footnotes in a post whose live version has footnotes

@maelle
Copy link
Member Author

maelle commented Nov 30, 2020

With this they are accessible via the number (click) not at the bottom

Screenshot_20201130-200700

@maelle
Copy link
Member Author

maelle commented Nov 30, 2020

(Which you are free to dislike, and which might just not work in your browser?)

@stefaniebutland
Copy link
Member

ah! Works for me in Chrome Version 87.0.4280.67 (Official Build) (x86_64)

It's great to see the footnote/ citation without going to bottom of post.

However, as with journal articles, I like to see the citations (aka footnotes here) listed at the bottom of the post. Is it easily possible to have both or should we choose?

@maelle
Copy link
Member Author

maelle commented Dec 1, 2020

At least if we use littlefoot.js we need to choose (I've just checked its docs).

@maelle
Copy link
Member Author

maelle commented Dec 1, 2020

but we could use something else, in distill blogs you get both.

@jeroen
Copy link
Member

jeroen commented Dec 8, 2020

I don't really like this. For example I had a little foot note on: https://ropensci.org/technotes/2020/11/19/moving-away-travis/

But with the new plugin this turns into a popup that isn't even the right size: https://deploy-preview-97--ropensci.netlify.app/technotes/2020/11/19/moving-away-travis/

I don't agree that popups result in a better "flow" than footnotes. I prefer old fashioned footnotes over widgets.

@jeroen
Copy link
Member

jeroen commented Dec 8, 2020

Also the problem with these widgets is that the popups start to overlap on mobile:

Screenshot_20201208-122442

@maelle maelle deleted the footnotes branch February 23, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tooltip when hovering over footnote numbers
3 participants