-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openalexR: an R package to interface with the OpenAlex API #560
Comments
Thanks for submitting to rOpenSci, our editors and @ropensci-review-bot will reply soon. Type |
🚀 Editor check started 👋 |
Checks for openalexR (v1.0.2)git hash: c0d32fea
Package License: MIT + file LICENSE 1. Package DependenciesDetails of Package Dependency Usage (click to open)
The table below tallies all function calls to all packages ('ncalls'), both internal (r-base + recommended, along with the package itself), and external (imported and suggested packages). 'NA' values indicate packages to which no identified calls to R functions could be found. Note that these results are generated by an automated code-tagging system which may not be entirely accurate.
Click below for tallies of functions used in each package. Locations of each call within this package may be generated locally by running 's <- pkgstats::pkgstats(<path/to/repo>)', and examining the 'external_calls' table. baselist (62), c (23), lapply (16), do.call (15), length (14), if (11), for (7), unlist (7), vector (6), mode (5), paste (5), is.null (4), lengths (4), names (3), rbind.data.frame (3), by (2), duplicated (2), max (2), min (2), nrow (2), rbind (2), rep (2), search (2), sort (2), switch (2), unique (2), url (2), which (2), as.character (1), ceiling (1), environment (1), format (1), grepl (1), intersect (1), is.na (1), logical (1), mapply (1), merge (1), paste0 (1), seq_along (1), seq.int (1), strsplit (1), tolower (1), vapply (1) openalexRoa_fetch (13), oa_progress (7), au_collapse (5), subs_na (5), empty_list (3), oa_request (3), SR (3), abstract_build (2), api_request (2), append_flt (2), cfg (2), oa_entities (2), simple_rapply (2), asl (1), authors2df (1), concepts2df (1), get_auth_position (1), id_type (1), institutions2df (1), isValidEmail (1), oa_email (1), oa_query (1), oa_random (1), oa_snowball (1), oa2bibliometrix (1), oa2df (1), prepend (1), shorten_oaid (1), shorten_orcid (1) utilsdata (16) statsfilter (11), setNames (1) httrcontent (2), GET (1), modify_url (1), user_agent (1) graphicstext (2) jsonlitefromJSON (2) methodsas (2) NOTE: Some imported packages appear to have no associated function calls; please ensure with author that these 'Imports' are listed appropriately. 2. Statistical PropertiesThis package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing. Details of statistical properties (click to open)
The package has:
Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
All parameters are explained as tooltips in the locally-rendered HTML version of this report generated by the The final measure (
2a. Network visualisationClick to see the interactive network visualisation of calls between objects in package 3.
|
id | name | conclusion | sha | run_number | date |
---|---|---|---|---|---|
3420154650 | pages build and deployment | success | 3a012b | 38 | 2022-11-08 |
3420037823 | pkgcheck | success | c0d32f | 2 | 2022-11-08 |
3420182325 | pkgdown | NA | c4e6ce | 88 | 2022-11-08 |
3420182323 | R-CMD-check | NA | c4e6ce | 73 | 2022-11-08 |
3420182324 | test-coverage | NA | c4e6ce | 30 | 2022-11-08 |
3b. goodpractice
results
R CMD check
with rcmdcheck
rcmdcheck found no errors, warnings, or notes
Test coverage with covr
Package coverage: 92.42
Cyclocomplexity with cyclocomp
The following functions have cyclocomplexity >= 15:
function | cyclocomplexity |
---|---|
oa_request | 19 |
works2df | 16 |
Static code analyses with lintr
lintr found the following 74 potential issues:
message | number of times |
---|---|
Avoid library() and require() calls in packages | 9 |
Lines should not be more than 80 characters. | 65 |
Package Versions
package | version |
---|---|
pkgstats | 0.1.1.66 |
pkgcheck | 0.1.0.32 |
Editor-in-Chief Instructions:
This package is in top shape and may be passed on to a handling editor
Thanks for submitting @trangdata! 🎉 I'm in the process of assigning a handling editor. In the meantime, it appears there's a minor discrepancy in the version stated in the submission and pasted |
Thanks so much @annakrystalli! 🌻
Ah my bad. I forgot to update the version. Edited now. |
@ropensci-review-bot assign @ldecicco-USGS as editor |
Assigned! @ldecicco-USGS is now the editor |
Editor checks:
Editor comments |
Hi @trangdata ! The package looks great! I'll try to find some editors as soon as possible |
Thank you so much @ldecicco-USGS. 🪴 And you mean reviewers right? 😅 |
😆Yup! |
@ropensci-review-bot assign @BriannaLind as reviewer |
@BriannaLind added to the reviewers list. Review due date is 2022-12-22. Thanks @BriannaLind for accepting to review! Please refer to our reviewer guide. rOpenSci’s community is our best asset. We aim for reviews to be open, non-adversarial, and focused on improving software quality. Be respectful and kind! See our reviewers guide and code of conduct for more. |
@BriannaLind: If you haven't done so, please fill this form for us to update our reviewers records. |
Sorry for the delay team - I am diving into the review, will get back asap |
It turns out I had assigned the review to a fake account that was impersonating the actual reviewer. I'm verifying he's still interested in reviewing. Sorry for the delay @trangdata ! |
@ropensci-review-bot assign @pachadotdev as reviewer |
@pachadotdev added to the reviewers list. Review due date is 2023-01-24. Thanks @pachadotdev for accepting to review! Please refer to our reviewer guide. rOpenSci’s community is our best asset. We aim for reviews to be open, non-adversarial, and focused on improving software quality. Be respectful and kind! See our reviewers guide and code of conduct for more. |
Hi @pachadotdev and @BriannaLind , checking in to see if you could update us on an approximate timeline for when you'll be able to do the review. |
@BriannaLind ah gotcha! That makes sense. I'll keep this in mind when updating the readme.
@pachadotdev Thank you!!! I'm excited to hear your feedback! 🙌🏽 |
Dear all, My EiC rotation just started and I'm checking the status of open issues. I don't mean to intrude but to save you time. So while I'm here I note the second review might be ready soon. @pachadotdev, any updates? |
hi! |
ready |
Hi @pachadotdev - copy and paste the text in the comments. If there are any formatting issues I can take a look and see how to fix it up. |
Package Review (1)Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
DocumentationThe package includes all the following forms of documentation:
Functionality
Estimated hours spent reviewing: 3.5
Review CommentsSorry for the delay! The outputs look strange on Windows, but it works perfect on Ubuntu. After checking, it is because I had older pkgs on Windows. |
Package ReviewPlease check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
DocumentationThe package includes all the following forms of documentation:
Functionality
Estimated hours spent reviewing: 3.5
Review CommentsSorry for the delay! The outputs look strange on Windows, but it works perfect on Ubuntu. After checking, it is because I had older pkgs on Windows. |
@ropensci-review-bot submit review #560 (comment) time 3.5 |
Couldn't find entry for pachadotdev in the reviews log |
@ropensci-review-bot submit review #560 (comment) time 6 |
Logged review for BriannaLind (hours: 6) |
Thanks @pachadotdev and @BriannaLind for the reviews! It seems like you both gave the package a test drive and things are looking pretty good. I don't see any major suggestions that were put forth yet to fix. Is that right? When I first looked at the package via the editor review, I also thought it was in pretty good shape! If that's correct, @pachadotdev and @BriannaLind , could you use the Approval template and verify: |
Reviewer ResponseFinal approval (post-review)
Estimated hours spent reviewing: 6 |
Reviewer ResponseFinal approval (post-review)
Estimated hours spent reviewing: 3.5 |
@ropensci-review-bot approve openalexR |
Approved! Thanks @trangdata for submitting and @BriannaLind, @pachadotdev for your reviews! 😁 To-dos:
Should you want to acknowledge your reviewers in your package DESCRIPTION, you can do so by making them Welcome aboard! We'd love to host a post about your package - either a short introduction to it with an example for a technical audience or a longer post with some narrative about its development or something you learned, and an example of its use for a broader readership. If you are interested, consult the blog guide, and tag @ropensci/blog-editors in your reply. They will get in touch about timing and can answer any questions. We maintain an online book with our best practice and tips, this chapter starts the 3d section that's about guidance for after onboarding (with advice on releases, package marketing, GitHub grooming); the guide also feature CRAN gotchas. Please tell us what could be improved. Last but not least, you can volunteer as a reviewer via filling a short form. |
@trangdata Congratulations on the great package. Sorry the timing went a little longer than usual. The "bot" automatically closes this issue when the package gets approved, but we can still use the issue to communicate (or feel free to re-open it if you have any questions). Let me know if you have any questions on the instructions above. Once again, thanks for submitting to rOpenSci and great work! 🎉 |
@ldecicco-USGS Thank you so much! ❤️ And huge thank you to the reviewers @pachadotdev and @BriannaLind for your valuable feedback! 🌈 Would you both be okay with us listing you as reviewers in our DESCRIPTION file? On the first TODO: @ldecicco-USGS Could you please add (or ask the bot to add) @massimoaria to ropensci so he could transfer "ownership" of the repository, please? The package currently lives at https://github.com/massimoaria/openalexR. Thank you! |
I sent an invitation to the organization to @massimoaria. Please ping me when the repo is transferred so that I might give @massimoaria admin access back. Sorry for the clunkiness, it's only the second time in a short time we encounter this case ropensci-org/buffy#98 |
Dear Maelle,
I just transferred the openalexR repository to the rOpenSci organization.
Thanks a lot
Massimo
****************************************************
Dr. Massimo Aria
Full Professor in Statistics for Social Sciences
PhD in Computational Statistics
Bibliometrix R-package creator
K-Synth Academic Spin-Off co-founder
Department of Economics and Statistics
University of Naples Federico II
Monte S. Angelo, via Cinthia I-80126 Napoli, Italy
Room D-25, Sector D, 2nd Floor, Building 3
ph. +39 081675187
fax +39 081675009
mob. +39 392 1966384
email ***@***.***
https://www.massimoaria.com
https://www.bibliometrix.org
https://www.k-synth.unina.it
https://scholar.google.it/citations?user=Qu66YZQAAAAJ
https://orcid.org/0000-0002-8517-9411
http://www.researcherid.com/rid/O-7983-2015
https://www.researchgate.net/profile/Massimo_Aria
****************************************************
… Il giorno 24 feb 2023, alle ore 06:30, Maëlle Salmon ***@***.***> ha scritto:
I sent an invitation to the organization to @massimoaria <https://github.com/massimoaria>. Please ping me when the repo is transferred so that I might give @massimoaria <https://github.com/massimoaria> admin access back.
Sorry for the clunkiness, it's only the second time in a short time we encounter this case ropensci-org/buffy#98 <ropensci-org/buffy#98>
—
Reply to this email directly, view it on GitHub <#560 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD2H753KTTIRCVTQW4UFTKDWZBBRDANCNFSM6AAAAAAR2LR6UE>.
You are receiving this because you were mentioned.
|
Awesome, thanks! I've given you admin rights and write access to @trangdata but now that you have admin rights you can increase @trangdata's as needed. |
@massimoaria Any chance you could give me admin access so it's easier for me to make changes such as change the repo description url. Thank you! 🌱 |
Done! |
Date accepted: 2023-02-23
Submitting Author Name: Trang Le
Due date for @BriannaLind: 2022-12-22Submitting Author Github Handle: @trangdata
Other Package Authors Github handles: (comma separated, delete if none) @massimoaria
Repository: https://github.com/massimoaria/openalexR
Version submitted: 1.0.2
Submission type: Standard
Editor: @ldecicco-USGS
Reviewers: @BriannaLind, @pachadotdev
Due date for
Due date for @pachadotdev: 2023-01-24
Archive: TBD
Version accepted: TBD
Language: en
Scope
Please indicate which category or categories from our package fit policies this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):
Explain how and why the package falls under these categories (briefly, 1-2 sentences): The package interacts with the OpenAlex API. Similar packages in the same category are rcrossref and rotl.
Who is the target audience and what are scientific applications of this package?
Anyone who wants to work in R to interact with the OpenAlex API to acquire information on publications, authors, etc., including researchers in the field of bibliometrics, text mining, etc. We include several example analyses in our README.
Are there other R packages that accomplish the same thing? If so, how does yours differ or meet our criteria for best-in-category?
Please see the detailed answer here with a detailed table of comparison and examples of code differences.
(If applicable) Does your package comply with our guidance around Ethics, Data Privacy and Human Subjects Research?
Yes.
If you made a pre-submission inquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted.
Presubmission inquiry - openalexR: interacts with OpenAlex API #557
Explain reasons for any
pkgcheck
items which your package is unable to pass.N/A. Passed all checks.
Technical checks
Confirm each of the following by checking the box.
This package:
Publication options
Do you intend for this package to go on CRAN?
Do you intend for this package to go on Bioconductor?
Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? If so:
MEE Options
Code of conduct
The text was updated successfully, but these errors were encountered: