From 59c38f3453becfc04cc37fa9ed9bda01307eb1be Mon Sep 17 00:00:00 2001 From: v4hn Date: Thu, 20 Oct 2022 09:36:05 +0900 Subject: [PATCH 1/5] do away with boost::bind literal boost _1 has been deprecated for a long time due to std::bind. Using lambas instead is strongly encouraged. --- libuvc_camera/src/camera_driver.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libuvc_camera/src/camera_driver.cpp b/libuvc_camera/src/camera_driver.cpp index aa4abce..24ab7ef 100644 --- a/libuvc_camera/src/camera_driver.cpp +++ b/libuvc_camera/src/camera_driver.cpp @@ -78,7 +78,7 @@ bool CameraDriver::Start() { state_ = kStopped; - config_server_.setCallback(boost::bind(&CameraDriver::ReconfigureCallback, this, _1, _2)); + config_server_.setCallback([this](auto& config, auto level){ ReconfigureCallback(config, level); }); return state_ == kRunning; } From 2b187b0282a46a460d3ace9e30f0079562aa04a9 Mon Sep 17 00:00:00 2001 From: v4hn Date: Thu, 20 Oct 2022 09:36:53 +0900 Subject: [PATCH 2/5] adapt pluginlib header *.h includes have been deprecated for a long time. --- libuvc_camera/src/nodelet.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libuvc_camera/src/nodelet.cpp b/libuvc_camera/src/nodelet.cpp index 91d2f3c..38246d8 100644 --- a/libuvc_camera/src/nodelet.cpp +++ b/libuvc_camera/src/nodelet.cpp @@ -32,7 +32,7 @@ * POSSIBILITY OF SUCH DAMAGE. *********************************************************************/ #include -#include +#include #include #include "libuvc_camera/camera_driver.h" From f63727aae268af887f4e086c702e8935ab602dc0 Mon Sep 17 00:00:00 2001 From: v4hn Date: Wed, 26 Jun 2024 13:19:00 +0200 Subject: [PATCH 3/5] support modern libuvc cmake target Required in libuvc 0.0.7. --- libuvc_camera/CMakeLists.txt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libuvc_camera/CMakeLists.txt b/libuvc_camera/CMakeLists.txt index 91db504..48f281c 100644 --- a/libuvc_camera/CMakeLists.txt +++ b/libuvc_camera/CMakeLists.txt @@ -7,7 +7,13 @@ find_package(catkin REQUIRED COMPONENTS roscpp camera_info_manager dynamic_recon generate_dynamic_reconfigure_options(cfg/UVCCamera.cfg) find_package(libuvc REQUIRED) -message(STATUS "libuvc ${libuvc_VERSION_MAJOR}.${libuvc_VERSION_MINOR}.${libuvc_VERSION_PATCH}") +# if libuvc_LIBRARIES are empty, check cmake target +if(NOT libuvc_LIBRARIES AND TARGET LibUVC::UVCShared) + set(libuvc_LIBRARIES LibUVC::UVCShared) +endif() +if(NOT libuvc_LIBRARIES) + message(FATAL_ERROR "could not find expected libuvc libraries in package") +endif() catkin_package( CATKIN_DEPENDS From a427699c1c96effa287db8028d93b17e3ce217f7 Mon Sep 17 00:00:00 2001 From: Robert Haschke Date: Thu, 9 Jan 2025 14:23:43 +0100 Subject: [PATCH 4/5] Fix dependency on libuvc-dev --- libuvc_camera/package.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libuvc_camera/package.xml b/libuvc_camera/package.xml index 2b80d27..4b6fba9 100644 --- a/libuvc_camera/package.xml +++ b/libuvc_camera/package.xml @@ -17,8 +17,7 @@ camera_info_manager dynamic_reconfigure image_transport - libuvc - libuvc-dev + libuvc-dev nodelet sensor_msgs From 3b2bbc6015195c69582fabaac92233f499c287de Mon Sep 17 00:00:00 2001 From: Robert Haschke Date: Thu, 9 Jan 2025 20:45:13 +0100 Subject: [PATCH 5/5] Add missing dependency on libusb-1.0-dev --- libuvc_camera/package.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/libuvc_camera/package.xml b/libuvc_camera/package.xml index 4b6fba9..f937dbb 100644 --- a/libuvc_camera/package.xml +++ b/libuvc_camera/package.xml @@ -18,6 +18,7 @@ dynamic_reconfigure image_transport libuvc-dev + libusb-1.0-dev nodelet sensor_msgs