Fixup: Call DockWidgets::setFloating() after addDockWidget

Author: rhaschke

src/python_bindings/sip/visualization_frame.sip

@@ -35,7 +35,7 @@ public:
   virtual rviz::PanelDockWidget* addPane( const QString& name,
                                 QWidget* panel,
                                 Qt::DockWidgetArea area = Qt::LeftDockWidgetArea,
-                                bool floating = true );
+                                bool floating = false );
 
   /** @brief Load the "general" config file, which has just the few
    * things which should not be saved with a display config.
@@ -60,7 +60,7 @@ public:
   QString getErrorMessage() const;
 
   /** @brief Load the properties of all subsystems from the given Config.
-   * 
+   *
    * This is called by loadDisplayConfig().
    *
    * @param config Must have type Config::Map.

src/rviz/visualization_frame.cpp

@@ -1417,12 +1417,10 @@ VisualizationFrame::addPane(const QString& name, QWidget* panel, Qt::DockWidgetA
 {
   PanelDockWidget* dock;
   dock = new PanelDockWidget(name);
-  if (floating) // "floating" mutually excludes "docked"
-    dock->setFloating(floating);
-  else
-    addDockWidget(area, dock);
+  addDockWidget(area, dock);
 
   dock->setContentWidget(panel);
+  dock->setFloating(floating);
   dock->setObjectName(name); // QMainWindow::saveState() needs objectName to be set.
 
   // we want to know when that panel becomes visible