From 4275fe6efb6981346c04dfa3a481ad25221cbaf7 Mon Sep 17 00:00:00 2001 From: Vaibhav Shende <91043775+Tenveis@users.noreply.github.com> Date: Sat, 3 May 2025 15:59:52 -0400 Subject: [PATCH 1/2] updated the document to add optional dependency in package.xml --- .../Using-Parameters-In-A-Class-Python.rst | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst b/source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst index d2008b8e18f..c3e3ae291ae 100644 --- a/source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst +++ b/source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst @@ -186,6 +186,15 @@ For that to work, the ``__init__`` code has to be changed to: self.timer = self.create_timer(1, self.timer_callback) +Since we are importing ``rcl_interfaces``, we need to add the dependency to ``package.xml`` to avoid any dependency issue in the future. + +.. code-block:: xml + + # ... + + Apache-2.0 + rclpy + rcl_interfaces The rest of the code remains the same. Once you run the node, you can then run ``ros2 param describe /minimal_param_node my_parameter`` to see the type and description. From 29e336059246d23a58aed6fc63618daa271f328b Mon Sep 17 00:00:00 2001 From: Katherine Scott Date: Tue, 8 Jul 2025 10:31:50 -0700 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Christophe Bedard Signed-off-by: Katherine Scott --- .../Using-Parameters-In-A-Class-Python.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst b/source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst index c3e3ae291ae..c055fcf8e2e 100644 --- a/source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst +++ b/source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst @@ -186,13 +186,11 @@ For that to work, the ``__init__`` code has to be changed to: self.timer = self.create_timer(1, self.timer_callback) -Since we are importing ``rcl_interfaces``, we need to add the dependency to ``package.xml`` to avoid any dependency issue in the future. +Since we are importing ``rcl_interfaces``, we need to add the dependency to ``package.xml`` to avoid any dependency issue in the future: .. code-block:: xml # ... - - Apache-2.0 rclpy rcl_interfaces