You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OS Version: Ubuntu 24.04
rviz version: ros2 jazzy
Compiler name and version number: Ubuntu clang version 18.1.3
Source or binary build?
source build
build options: --mixin asan-gcc
Description:
When executing the SelectionManager::select function, invalid coordinates (such as negative coordinates or coordinates outside the rendering window) are not handled correctly in the pick function, leading to the erroneous selection of objects that should not be selected. This is reflected in the failure of the unit test SelectionManagerTestFixture.select_handles_invalid_coordinates_gracefully, where the expected selection result is empty, but the actual result contains selected objects.
Steps to Reproduce:
1.In the SelectionManagerTestFixture.select_handles_invalid_coordinates_gracefully test, pass an invalid selection region (e.g., negative coordinates -10, -10).
2.Call the SelectionManager::select function and expect an empty selection result.
3.Actual result: The selection result returned contains one object, with a size of 1 instead of the expected size 0.
Running main() from gmock_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from SelectionManagerTestFixture
[ RUN ] SelectionManagerTestFixture.select_handles_invalid_coordinates_gracefully
[rviz_rendering:debug] Available Renderers(1): OpenGL Rendering Subsystem, at /home/shangzh/ros2_jazzy/src/ros2/rviz/rviz_rendering/src/rviz_rendering/render_system.cpp:289
[rviz_rendering:info] Stereo is NOT SUPPORTED, at /home/shangzh/ros2_jazzy/src/ros2/rviz/rviz_rendering/src/rviz_rendering/render_system.cpp:531
[rviz_rendering:info] OpenGl version: 4.3 (GLSL 4.3), at /home/shangzh/ros2_jazzy/src/ros2/rviz/rviz_rendering/src/rviz_rendering/render_system.cpp:272
/home/shangzh/ros2_jazzy/src/ros2/rviz/rviz_common/test/interaction/selection_manager_test.cpp:36: Failure
Value of: selection
Expected: has a size that is equal to 0
Actual: { (8388608, 56-byte object <00-00 80-00 01-00 00-00 BE-BE BE-BE BE-BE BE-BE 00-00 00-00 BE-BE BE-BE 00-00 00-00 00-00 00-00 20-AB 0A-00 70-50 00-00 20-AB 0A-00 70-50 00-00 00-00 00-00 00-00 00-00>) }, whose size 1 doesn't match
[ FAILED ] SelectionManagerTestFixture.select_handles_invalid_coordinates_gracefully (2060 ms)
[----------] 1 test from SelectionManagerTestFixture (2060 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (2060 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] SelectionManagerTestFixture.select_handles_invalid_coordinates_gracefully
1 FAILED TEST
Expected behavior
When passing invalid coordinate regions (such as negative coordinates or coordinates outside the rendering window), the pick function should correctly handle these invalid coordinates and return an empty selection result without any selected objects.
Actual behavior
Even with invalid coordinates, the pick function still returns a selection result containing one object, leading to the test failure. The error message is as follows:
Value of: selection
Expected: has a size that is equal to 0
Actual: { (8388608, 56-byte object <00-00 80-00 01-00 00-00 BE-BE BE-BE BE-BE BE-BE 00-00 00-00 BE-BE BE-BE 00-00 00-00 00-00 00-00 20-AB 0A-00 70-50 00-00 20-AB 0A-00 70-50 00-00 00-00 00-00 00-00 00-00>) }, whose size 1 doesn't match
Additional information
No response
The text was updated successfully, but these errors were encountered:
Operating System:
Linux shangzh-VMware-Virtual-Platform 6.11.0-19-generic #19~24.04.1-Ubuntu SMP PREEMPT_DYNAMIC Mon Feb 17 11:51:52 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
ROS version or commit hash:
ros 2 jazzy
RMW implementation (if applicable):
No response
RMW Configuration (if applicable):
No response
Client library (if applicable):
rviz
'ros2 doctor --report' output
ros2 doc --report
Steps to reproduce issue
Environment
OS Version: Ubuntu 24.04
rviz version: ros2 jazzy
Compiler name and version number: Ubuntu clang version 18.1.3
Source or binary build?
source build
build options: --mixin asan-gcc
Description:
When executing the SelectionManager::select function, invalid coordinates (such as negative coordinates or coordinates outside the rendering window) are not handled correctly in the pick function, leading to the erroneous selection of objects that should not be selected. This is reflected in the failure of the unit test SelectionManagerTestFixture.select_handles_invalid_coordinates_gracefully, where the expected selection result is empty, but the actual result contains selected objects.
Steps to Reproduce:
1.In the SelectionManagerTestFixture.select_handles_invalid_coordinates_gracefully test, pass an invalid selection region (e.g., negative coordinates -10, -10).
2.Call the SelectionManager::select function and expect an empty selection result.
3.Actual result: The selection result returned contains one object, with a size of 1 instead of the expected size 0.
Test Case:
Output:
Expected behavior
When passing invalid coordinate regions (such as negative coordinates or coordinates outside the rendering window), the pick function should correctly handle these invalid coordinates and return an empty selection result without any selected objects.
Actual behavior
Even with invalid coordinates, the pick function still returns a selection result containing one object, leading to the test failure. The error message is as follows:
Additional information
No response
The text was updated successfully, but these errors were encountered: