fix(test): register field indexer in controller test suite

The mapWorkloadToAgentCards test fails because suite_test.go creates a
plain client.New() without a ctrl.Manager, so the field indexer for
.spec.targetRef.name is never registered. Add a Manager in BeforeSuite
to register the AgentCard targetRef index and expose indexedClient for
tests that need field-indexed queries. Existing tests keep using the
plain k8sClient unchanged.

Fixes #351

Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: cwiklik <cwiklikj@gmail.com>

Author: cwiklik

kagenti-operator/internal/controller/indexers_test.go

@@ -110,7 +110,7 @@ var _ = Describe("mapWorkloadToAgentCards", func() {
 			sbx.SetNamespace(namespace)
 			sbx.SetLabels(map[string]string{LabelAgentType: LabelValueAgent})
 
-			mapFn := mapWorkloadToAgentCards(k8sClient, "agents.x-k8s.io/v1alpha1", "Sandbox", logger)
+			mapFn := mapWorkloadToAgentCards(indexedClient, "agents.x-k8s.io/v1alpha1", "Sandbox", logger)
 			requests := mapFn(ctx, sbx)
 			Expect(requests).To(HaveLen(1))
 			Expect(requests[0].Name).To(Equal("sandbox-card"))

kagenti-operator/internal/controller/suite_test.go

@@ -28,10 +28,12 @@ import (
 	appsv1 "k8s.io/api/apps/v1"
 	"k8s.io/client-go/kubernetes/scheme"
 	"k8s.io/client-go/rest"
+	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/envtest"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
+	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 
 	agentv1alpha1 "github.com/kagenti/operator/api/v1alpha1"
 	// +kubebuilder:scaffold:imports
@@ -41,11 +43,12 @@ import (
 // http://onsi.github.io/ginkgo/ to learn more about Ginkgo.
 
 var (
-	ctx       context.Context
-	cancel    context.CancelFunc
-	testEnv   *envtest.Environment
-	cfg       *rest.Config
-	k8sClient client.Client
+	ctx           context.Context
+	cancel        context.CancelFunc
+	testEnv       *envtest.Environment
+	cfg           *rest.Config
+	k8sClient     client.Client
+	indexedClient client.Client
 )
 
 func TestControllers(t *testing.T) {
@@ -87,6 +90,22 @@ var _ = BeforeSuite(func() {
 	k8sClient, err = client.New(cfg, client.Options{Scheme: scheme.Scheme})
 	Expect(err).NotTo(HaveOccurred())
 	Expect(k8sClient).NotTo(BeNil())
+
+	mgr, err := ctrl.NewManager(cfg, ctrl.Options{
+		Scheme:  scheme.Scheme,
+		Metrics: metricsserver.Options{BindAddress: "0"},
+	})
+	Expect(err).NotTo(HaveOccurred())
+
+	err = RegisterAgentCardTargetRefIndex(mgr)
+	Expect(err).NotTo(HaveOccurred())
+
+	go func() {
+		defer GinkgoRecover()
+		Expect(mgr.Start(ctx)).To(Succeed())
+	}()
+
+	indexedClient = mgr.GetClient()
 })
 
 var _ = AfterSuite(func() {