Skip to content

README §Installation: update-secrets.sh behaviour around HF_TOKEN misdocumented #39

Description

@yoavkatz

Summary

Two README ↔ code drifts found during cold-turkey testing:

1. update-secrets.sh and hf-secret

README §"Installation" (line 191) says update-secrets.sh "Creates/updates hf-secret (skips token if not set)". The actual script skips entirely if HF_TOKEN is unset, leaving hf-secret absent. On kind this causes:

CreateContainerConfigError: secret "hf-secret" not found

Either the README is wrong (it should say the secret is only created when HF_TOKEN is set) or the script should create a placeholder secret so the MCP pod can start.

2. OPENAI_API_BASE documented as optional but practically mandatory

OPENAI_API_BASE is documented on line 79 as the variable to point at your endpoint, but listed on line 201 as "optional". When using an OpenAI-compatible proxy (which the default openai/Azure/gpt-4.1 model requires), leaving it unset causes every LLM call to return Incorrect API key even after update-secrets.sh has patched the key correctly.

The README should clarify: "OPENAI_API_BASE is required when using an OpenAI-compatible proxy."

Found in

PR #33 review by @kellyaa.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions