Send 'replaylog:begin' when trying to execute beyond the beginning of time

rocallahan · rocallahan · commit 11b2f31b700f · 2024-07-18T08:50:14.000+12:00
diff --git a/src/GdbServer.cc b/src/GdbServer.cc
@@ -1069,6 +1069,9 @@ void GdbServer::maybe_notify_stop(const Session& session,
       } else {
         // The start of the debuggee task-group should trigger a silent stop.
         stop_siginfo.si_signo = 0;
+        // Documented as "has reached the end (or the beginning when executing
+        // backward) of the log"
+        reason << "replaylog:begin;";
         LOG(debug) << "Stopping at start of execution while running backwards";
       }
     }
diff --git a/src/test/dlopen.py b/src/test/dlopen.py
@@ -5,6 +5,6 @@
 expect_gdb('EXIT-SUCCESS')
 expect_gdb('SIGKILL')
 send_gdb('reverse-continue')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/mmap_replace_most_mappings.py b/src/test/mmap_replace_most_mappings.py
@@ -9,7 +9,7 @@
 send_gdb('restart 1')
 expect_gdb('stopped')
 send_gdb('rc')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('restart 1')
 expect_gdb('stopped')
 send_gdb('c')
diff --git a/src/test/mprotect_checkpoint.py b/src/test/mprotect_checkpoint.py
@@ -11,6 +11,6 @@
 send_gdb('ignore 1 1000000')
 expect_gdb('Will ignore')
 send_gdb('reverse-continue')
-expect_gdb('Program stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/ptrace_remote_unmap.py b/src/test/ptrace_remote_unmap.py
@@ -9,6 +9,6 @@
 send_gdb('restart 1')
 expect_gdb('stopped')
 send_gdb('rc')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/reverse_continue_exec_subprocess.py b/src/test/reverse_continue_exec_subprocess.py
@@ -2,25 +2,25 @@
 import re
 
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-stepi')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 send_gdb('b main')
 expect_gdb('Breakpoint 1')
 send_gdb('c')
 expect_gdb('Breakpoint 1')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-stepi')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/reverse_continue_fork_subprocess.py b/src/test/reverse_continue_fork_subprocess.py
@@ -2,29 +2,29 @@
 import re
 
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-stepi')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 send_gdb('stepi')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-stepi')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 send_gdb('stepi')
 send_gdb('reverse-stepi')
 send_gdb('reverse-stepi')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/reverse_continue_int3.py b/src/test/reverse_continue_int3.py
@@ -7,6 +7,6 @@
 expect_gdb('SIGTRAP')
 
 send_gdb('rc')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/reverse_continue_process_signal.py b/src/test/reverse_continue_process_signal.py
@@ -5,6 +5,6 @@
 send_gdb('c')
 expect_gdb('SIGKILL')
 send_gdb('reverse-continue')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/reverse_continue_start.py b/src/test/reverse_continue_start.py
@@ -2,20 +2,20 @@
 import re
 
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-stepi')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('b main')
 expect_gdb('Breakpoint 1')
 send_gdb('c')
 expect_gdb('Breakpoint 1')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-stepi')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/reverse_step_signal.py b/src/test/reverse_step_signal.py
@@ -25,6 +25,6 @@
 expect_gdb('received signal')
 
 send_gdb('reverse-continue')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/reverse_watchpoint.py b/src/test/reverse_watchpoint.py
@@ -29,6 +29,6 @@
 expect_gdb('New value = 0')
 
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/simple_winch.py b/src/test/simple_winch.py
@@ -13,6 +13,6 @@
 expect_gdb('Breakpoint 1')
 send_gdb('!kill -WINCH 0')
 send_gdb('reverse-cont')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/stack_overflow_debug.py b/src/test/stack_overflow_debug.py
@@ -14,6 +14,6 @@
 send_gdb('reverse-stepi')
 expect_gdb('SIGSEGV')
 send_gdb('reverse-continue')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()
diff --git a/src/test/vfork_read_clone_stress.py b/src/test/vfork_read_clone_stress.py
@@ -7,7 +7,7 @@
 expect_gdb('Program received signal SIGKILL')
 
 send_gdb('rc')
-expect_gdb('Program stopped.')
+expect_gdb('No more reverse-execution history')
 
 send_gdb('c')
 ok()
diff --git a/src/test/watch_code.py b/src/test/watch_code.py
@@ -9,6 +9,6 @@
 expect_gdb('Hardware watchpoint 2')
 
 send_gdb('reverse-continue')
-expect_gdb('stopped')
+expect_gdb('No more reverse-execution history')
 
 ok()

Original file line number	Diff line number	Diff line change
`@@ -1069,6 +1069,9 @@ void GdbServer::maybe_notify_stop(const Session& session,`
`1069`	`1069`	`} else {`
`1070`	`1070`	`// The start of the debuggee task-group should trigger a silent stop.`
`1071`	`1071`	`stop_siginfo.si_signo = 0;`
	`1072`	`+ // Documented as "has reached the end (or the beginning when executing`
	`1073`	`+ // backward) of the log"`
	`1074`	`+ reason << "replaylog:begin;";`
`1072`	`1075`	`LOG(debug) << "Stopping at start of execution while running backwards";`
`1073`	`1076`	`}`
`1074`	`1077`	`}`