Build folly from the travis before_script

Author: simpkins

.travis.yml

@@ -35,7 +35,7 @@ matrix:
     # are overriden by Travis. Setting the compiler in Travis doesn't work
     # either because it strips version.
 
-    - env: COMPILER=clang-4.0
+    - env: MATRIX_EVAL="CC=clang-4.0 && CXX=clang++-4.0"
       addons:
         apt:
           sources:
@@ -46,7 +46,7 @@ matrix:
             - clang-4.0
             - libstdc++-4.9-dev
 
-    - env: COMPILER=gcc-5
+    - env: MATRIX_EVAL="CC=gcc-5 && CXX=g++-5"
       addons:
         apt:
           sources:
@@ -56,7 +56,7 @@ matrix:
             - g++-5
             - libjemalloc-dev
 
-    - env: COMPILER=gcc-6
+    - env: MATRIX_EVAL="CC=gcc-6 && CXX=g++-6"
       addons:
         apt:
           sources:
@@ -85,12 +85,16 @@ before_script:
   # Install lcov to coveralls conversion + upload tool.
   - gem install coveralls-lcov
   - lcov --version
+  # Set CC and CXX based on the matrix environment
+  - eval "${MATRIX_EVAL}"
+  # Build folly
+  - mkdir build
+  - ./scripts/build_folly.sh build/folly-src build/folly-install
 
 script:
-  - mkdir build
   - cd build
-  - cmake -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DRSOCKET_CC=$COMPILER
-          -DRSOCKET_ASAN=$ASAN -DRSOCKET_INSTALL_DEPS=True
+  - cmake -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DRSOCKET_ASAN=$ASAN
+          -DCMAKE_PREFIX_PATH=$PWD/folly-install
           -DRSOCKET_BUILD_WITH_COVERAGE=ON ..
   - make -j4
   - lcov --directory . --zerocounters

scripts/build_folly.sh

@@ -9,6 +9,13 @@ if [[ -z $INSTALL_DIR ]]; then
   exit 1
 fi
 
+# Convert INSTALL_DIR to an absolute path so it still refers to the same
+# location after we cd into the build directory.
+case "$INSTALL_DIR" in
+  /*) ;;
+  *) INSTALL_DIR="$PWD/$INSTALL_DIR"
+esac
+
 # If folly was already installed, just return early
 INSTALL_MARKER_FILE="$INSTALL_DIR/folly.installed"
 if [[ -f $INSTALL_MARKER_FILE ]]; then
@@ -28,7 +35,11 @@ fi
 
 mkdir -p "$CHECKOUT_DIR/_build"
 cd "$CHECKOUT_DIR/_build"
-cmake "-DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}" ..
+if ! cmake "-DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}" ..; then
+    echo "error configuring folly" >&2
+    tail -n 100 CMakeFiles/CMakeError.log >&2
+    exit 1
+fi
 make -j4
 make install
 touch "$INSTALL_MARKER_FILE"